linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* slub statistics: Check the correct value for DEACTIVATE_REMOTE_FREES, slub statistics: Check the correct value for DEACTIVATE_REMOTE_FREES
@ 2008-03-04 19:34 Christoph Lameter, Christoph Lameter
  2008-03-04 19:39 ` Pekka Enberg
  0 siblings, 1 reply; 2+ messages in thread
From: Christoph Lameter, Christoph Lameter @ 2008-03-04 19:34 UTC (permalink / raw)
  To: Pekka J Enberg; +Cc: Matt Mackall, linux-mm

The remote frees are in the freelist of the page and not in the
percpu freelist.

Signed-off-by: Christoph Lameter <clameter@sgi.com>

---
 mm/slub.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6/mm/slub.c
===================================================================
--- linux-2.6.orig/mm/slub.c	2008-03-04 11:07:54.000000000 -0800
+++ linux-2.6/mm/slub.c	2008-03-04 11:08:30.000000000 -0800
@@ -1368,7 +1368,7 @@ static void deactivate_slab(struct kmem_
 	struct page *page = c->page;
 	int tail = 1;
 
-	if (c->freelist)
+	if (page->freelist)
 		stat(c, DEACTIVATE_REMOTE_FREES);
 	/*
 	 * Merge cpu freelist into slab freelist. Typically we get here

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: slub statistics: Check the correct value for DEACTIVATE_REMOTE_FREES
  2008-03-04 19:34 slub statistics: Check the correct value for DEACTIVATE_REMOTE_FREES, slub statistics: Check the correct value for DEACTIVATE_REMOTE_FREES Christoph Lameter, Christoph Lameter
@ 2008-03-04 19:39 ` Pekka Enberg
  0 siblings, 0 replies; 2+ messages in thread
From: Pekka Enberg @ 2008-03-04 19:39 UTC (permalink / raw)
  To: Christoph Lameter; +Cc: Matt Mackall, linux-mm

Christoph Lameter wrote:
> From: Christoph Lameter <clameter@sgi.com>
> Subject: slub statistics: Check the correct value for DEACTIVATE_REMOTE_FREES
> 
> The remote frees are in the freelist of the page and not in the
> percpu freelist.

Reviewed-by: Pekka Enberg <penberg@cs.helsinki.fi>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-03-04 19:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-04 19:34 slub statistics: Check the correct value for DEACTIVATE_REMOTE_FREES, slub statistics: Check the correct value for DEACTIVATE_REMOTE_FREES Christoph Lameter, Christoph Lameter
2008-03-04 19:39 ` Pekka Enberg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).