From: minchan Kim <minchan.kim@gmail.com>
To: Rik van Riel <riel@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Lee Schermerhorn <Lee.Schermerhorn@hp.com>
Subject: Re: [patch 16/20] non-reclaimable mlocked pages
Date: Wed, 05 Mar 2008 09:28:21 +0900 [thread overview]
Message-ID: <47CDE925.9090503@gmail.com> (raw)
In-Reply-To: <20080304225227.780021971@redhat.com>
Hi, Rik.
There is a some trivial mistake.
It can cause compile error.
>@@ -665,7 +677,12 @@ static int prep_new_page(struct page *pa
>
> page->flags &= ~(1 << PG_uptodate | 1 << PG_error | 1 << PG_readahead |
> 1 << PG_referenced | 1 << PG_arch_1 |
>- 1 << PG_owner_priv_1 | 1 << PG_mappedtodisk);
>+ 1 << PG_owner_priv_1 | 1 << PG_mappedtodisk |
>+#ifdef CONFIG_NORECLAIM_MLOCK
>+//TODO take care of it here, for now.
>+ 1 << PG_mlocked
>+#endif
>+ );
> set_page_private(page, 0);
> set_page_refcounted(page);
we need to fix it.
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 78c3f94..f6d535f 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -677,10 +677,10 @@ static int prep_new_page(struct page *page, int
order, gfp_t gfp_flags)
page->flags &= ~(1 << PG_uptodate | 1 << PG_error | 1 << PG_readahead |
1 << PG_referenced | 1 << PG_arch_1 |
- 1 << PG_owner_priv_1 | 1 << PG_mappedtodisk |
+ 1 << PG_owner_priv_1 | 1 << PG_mappedtodisk
#ifdef CONFIG_NORECLAIM_MLOCK
//TODO take care of it here, for now.
- 1 << PG_mlocked
+ | 1 << PG_mlocked
#endif
);
set_page_private(page, 0);
Thanks,
barrios.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-03-05 0:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-04 22:51 [patch 00/20] VM pageout scalability improvements (V5) Rik van Riel
2008-03-04 22:51 ` [patch 01/20] move isolate_lru_page() to vmscan.c Rik van Riel
2008-03-04 22:51 ` [patch 02/20] Use an indexed array for LRU variables Rik van Riel
2008-03-05 0:31 ` Johannes Weiner
2008-03-04 22:52 ` [patch 03/20] use an array for the LRU pagevecs Rik van Riel
2008-03-04 22:52 ` [patch 04/20] free swap space on swap-in/activation Rik van Riel
2008-03-04 22:52 ` [patch 05/20] define page_file_cache() function Rik van Riel
2008-03-04 22:52 ` [patch 06/20] split LRU lists into anon & file sets Rik van Riel
2008-03-04 22:52 ` [patch 07/20] SEQ replacement for anonymous pages Rik van Riel
2008-03-04 22:52 ` [patch 08/20] add some sanity checks to get_scan_ratio Rik van Riel
2008-03-04 22:52 ` [patch 09/20] add newly swapped in pages to the inactive list Rik van Riel
2008-03-04 22:52 ` [patch 10/20] more aggressively use lumpy reclaim Rik van Riel
2008-03-04 22:52 ` [patch 11/20] No Reclaim LRU Infrastructure Rik van Riel
2008-03-05 0:34 ` minchan Kim
2008-03-05 4:21 ` Rik van Riel
2008-03-04 22:52 ` [patch 12/20] Non-reclaimable page statistics Rik van Riel
2008-03-04 22:52 ` [patch 13/20] scan noreclaim list for reclaimable pages Rik van Riel
2008-03-04 22:52 ` [patch 14/20] ramfs pages are non-reclaimable Rik van Riel
2008-03-04 22:52 ` [patch 15/20] SHM_LOCKED pages are nonreclaimable Rik van Riel
2008-03-04 22:52 ` [patch 16/20] non-reclaimable mlocked pages Rik van Riel
2008-03-05 0:28 ` minchan Kim [this message]
2008-03-05 4:18 ` Rik van Riel
2008-03-04 22:52 ` [patch 17/20] mlock vma pages under mmap_sem held for read Rik van Riel
2008-03-04 22:52 ` [patch 18/20] handle mlocked pages during map/unmap and truncate Rik van Riel
2008-03-04 22:52 ` [patch 19/20] account mlocked pages Rik van Riel
2008-03-04 22:52 ` [patch 20/20] cull non-reclaimable anon pages from the LRU at fault time Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47CDE925.9090503@gmail.com \
--to=minchan.kim@gmail.com \
--cc=Lee.Schermerhorn@hp.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).