From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Christoph Lameter <clameter@sgi.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, mel@skynet.ie
Subject: Re: git-slub crashes on the t16p
Date: Thu, 10 Apr 2008 20:41:11 +0300 [thread overview]
Message-ID: <47FE5137.4000605@cs.helsinki.fi> (raw)
In-Reply-To: <Pine.LNX.4.64.0804101029270.11781@schroedinger.engr.sgi.com>
Christoph Lameter wrote:
> On Thu, 10 Apr 2008, Andrew Morton wrote:
>
>> That's within the call to atomic64_inc(), from the inc_slabs_node() here:
>
> Right. The slab counter cleanup patch did a non equivalent transformation
> here.
>
> Index: linux-2.6/mm/slub.c
> ===================================================================
> --- linux-2.6.orig/mm/slub.c 2008-04-10 10:27:29.000000000 -0700
> +++ linux-2.6/mm/slub.c 2008-04-10 10:28:02.000000000 -0700
> @@ -1174,6 +1174,8 @@
> if (!page)
> goto out;
>
> + /* Must use the node that the page allocator determined for us. */
> + node = page_to_nid(page);
> inc_slabs_node(s, node, page->objects);
> page->slab = s;
> page->flags |= 1 << PG_slab;
Actually, that's fixed in my tree since Saturday. So unfortunately I
don't think this is the problem...
Pekka
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-04-10 17:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-10 8:59 git-slub crashes on the t16p Andrew Morton
2008-04-10 9:34 ` Pekka Enberg
2008-04-10 10:27 ` Pekka J Enberg
2008-04-10 15:52 ` Pekka Enberg
2008-04-10 16:35 ` Pekka Enberg
2008-04-10 17:24 ` Andrew Morton
2008-04-10 17:30 ` Christoph Lameter
2008-04-10 17:41 ` Pekka Enberg [this message]
2008-04-10 17:45 ` Pekka Enberg
2008-04-10 17:51 ` Christoph Lameter
2008-04-10 17:54 ` Christoph Lameter
2008-04-10 18:00 ` Pekka Enberg
2008-04-10 18:03 ` Andrew Morton
2008-04-10 17:10 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47FE5137.4000605@cs.helsinki.fi \
--to=penberg@cs.helsinki.fi \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=linux-mm@kvack.org \
--cc=mel@skynet.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox