From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: Lorenzo Stoakes <ljs@kernel.org>
Cc: akpm@linux-foundation.org, david@kernel.org, hughd@google.com,
willy@infradead.org, ziy@nvidia.com, liam@infradead.org,
npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com,
baohua@kernel.org, lance.yang@linux.dev, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 00/11] add shmem mTHP collapse support
Date: Thu, 11 Jun 2026 19:46:55 +0800 [thread overview]
Message-ID: <47f472ac-0b07-4ffa-a3d4-04fba621252f@linux.alibaba.com> (raw)
In-Reply-To: <aipSe9Snx5x0esQx@lucifer>
Hi Lorenzo,
On 6/11/26 2:18 PM, Lorenzo Stoakes wrote:
> On Wed, Jun 10, 2026 at 06:29:08PM +0800, Baolin Wang wrote:
>> (Note: this patchset is not targeting v7.2, but posted for early feedback.)
>
> Hi Baolin,
>
> Speaking broadly, and to repeat what I said to Nico - I'd like to
> re-emphasise my _strong_ desire for us to pay down technical debt in THP
> code before adding any further major features.
>
> Really I'd have liked to see us do this _before_ khugepaged mTHP, but I
> didn't want to put Nico through more than he already endured with that
> series :)
>
> So I'd really like to see some action on that before we embark on any
> further significant changes.
>
> This is no comment on your changes, just something that we really need to
> address in THP generally.
>
> Will try to give some detailed commentary on the actual changes when I have
> time also :)
I fully understand the current state of THP maintenance, which is why
this is an RFC. I’m not expecting it to be merged into mainline quickly
(but thanks to Lance for the comments).
Also, as Nico noted, it might be worth reviewing the mTHP collapse
selftests in this series firstly? as they can help validate the
anonymous mTHP collapse path for future changes.
next prev parent reply other threads:[~2026-06-11 11:47 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 10:29 [RFC PATCH v2 00/11] add shmem mTHP collapse support Baolin Wang
2026-06-10 10:29 ` [RFC PATCH v2 01/11] mm: khugepaged: add max_ptes_none check in collapse_file() Baolin Wang
2026-06-12 10:10 ` Nico Pache
2026-06-10 10:29 ` [RFC PATCH v2 02/11] mm: khugepaged: generalize collapse_file() for shmem mTHP support Baolin Wang
2026-06-12 10:16 ` Nico Pache
2026-06-15 6:39 ` Baolin Wang
2026-06-10 10:29 ` [RFC PATCH v2 03/11] mm: khugepaged: add an order check for PMD-sized THP statistics Baolin Wang
2026-06-10 10:29 ` [RFC PATCH v2 04/11] mm: khugepaged: add shmem mTHP collapse support Baolin Wang
2026-06-10 12:13 ` Lance Yang
2026-06-11 0:31 ` Baolin Wang
2026-06-10 12:44 ` Lance Yang
2026-06-11 0:42 ` Baolin Wang
2026-06-11 2:47 ` Lance Yang
2026-06-11 11:15 ` Baolin Wang
2026-06-12 10:22 ` Nico Pache
2026-06-15 6:46 ` Baolin Wang
2026-06-11 6:06 ` Lance Yang
2026-06-11 12:11 ` Baolin Wang
2026-06-10 10:29 ` [RFC PATCH v2 05/11] mm: shmem: run khugepaged for all shmem mTHP orders Baolin Wang
2026-06-10 10:29 ` [RFC PATCH v2 06/11] mm: khugepaged: allow khugepaged to check all shmem mTHP-sized orders Baolin Wang
2026-06-10 11:33 ` Lance Yang
2026-06-11 0:47 ` Baolin Wang
2026-06-10 10:29 ` [RFC PATCH v2 07/11] mm: khugepaged: skip large folios that don't need to be collapsed Baolin Wang
2026-06-11 4:59 ` Lance Yang
2026-06-11 11:29 ` Baolin Wang
2026-06-10 10:29 ` [RFC PATCH v2 08/11] selftests: mm: extend the check_huge() to support mTHP check Baolin Wang
2026-06-12 10:32 ` Nico Pache
2026-06-15 6:51 ` Baolin Wang
2026-06-10 10:29 ` [RFC PATCH v2 09/11] selftests: mm: move gather_after_split_folio_orders() into vm_util.c file Baolin Wang
2026-06-10 10:29 ` [RFC PATCH v2 10/11] selftests: mm: implement the mTHP-sized hugepage check helpers Baolin Wang
2026-06-10 10:29 ` [RFC PATCH v2 11/11] selftests: mm: add mTHP collapse test cases Baolin Wang
2026-06-12 10:41 ` Nico Pache
2026-06-10 16:28 ` [RFC PATCH v2 00/11] add shmem mTHP collapse support Nico Pache
2026-06-11 0:52 ` Baolin Wang
2026-06-11 6:18 ` Lorenzo Stoakes
2026-06-11 11:46 ` Baolin Wang [this message]
2026-06-11 12:15 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47f472ac-0b07-4ffa-a3d4-04fba621252f@linux.alibaba.com \
--to=baolin.wang@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=hughd@google.com \
--cc=lance.yang@linux.dev \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=npache@redhat.com \
--cc=ryan.roberts@arm.com \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox