From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sd0109e.au.ibm.com (d23rh905.au.ibm.com [202.81.18.225]) by e23smtp02.au.ibm.com (8.13.1/8.13.1) with ESMTP id m5BHXhcH023576 for ; Thu, 12 Jun 2008 03:33:43 +1000 Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by sd0109e.au.ibm.com (8.13.8/8.13.8/NCO v9.0) with ESMTP id m5BHbijM210032 for ; Thu, 12 Jun 2008 03:37:44 +1000 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m5BHXWrh025315 for ; Thu, 12 Jun 2008 03:33:33 +1000 Message-ID: <48500C66.7040807@linux.vnet.ibm.com> Date: Wed, 11 Jun 2008 23:03:26 +0530 From: Balbir Singh Reply-To: balbir@linux.vnet.ibm.com MIME-Version: 1.0 Subject: Re: [-mm][PATCH 2/4] Setup the memrlimit controller (v5) References: <20080521152921.15001.65968.sendpatchset@localhost.localdomain> <20080521152948.15001.39361.sendpatchset@localhost.localdomain> <4850070F.6060305@gmail.com> In-Reply-To: <4850070F.6060305@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: righi.andrea@gmail.com Cc: linux-mm@kvack.org, Sudhir Kumar , YAMAMOTO Takashi , Paul Menage , lizf@cn.fujitsu.com, linux-kernel@vger.kernel.org, Pavel Emelianov , Andrew Morton , KAMEZAWA Hiroyuki List-ID: Andrea Righi wrote: > Balbir Singh wrote: >> +static int memrlimit_cgroup_write_strategy(char *buf, unsigned long >> long *tmp) >> +{ >> + *tmp = memparse(buf, &buf); >> + if (*buf != '\0') >> + return -EINVAL; >> + >> + *tmp = PAGE_ALIGN(*tmp); >> + return 0; >> +} > > We shouldn't use PAGE_ALIGN() here, otherwise we limit the address space > to 4GB on 32-bit architectures (that could be reasonable, because this > is a per-cgroup limit and not per-process). > You mean un-reasonable? > Signed-off-by: Andrea Righi Seems fair enough. Acked-by: Balbir Singh -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org