From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: righi.andrea@gmail.com, linux-mm@kvack.org,
skumar@linux.vnet.ibm.com, yamamoto@valinux.co.jp,
menage@google.com, lizf@cn.fujitsu.com,
linux-kernel@vger.kernel.org, xemul@openvz.org,
kamezawa.hiroyu@jp.fujitsu.com
Subject: Re: [-mm][PATCH 2/4] Setup the memrlimit controller (v5)
Date: Thu, 12 Jun 2008 11:43:47 +0530 [thread overview]
Message-ID: <4850BE9B.5030504@linux.vnet.ibm.com> (raw)
In-Reply-To: <20080611155530.099a54d6.akpm@linux-foundation.org>
Andrew Morton wrote:
>
> #define PAGE_ALIGN(addr) ALIGN(addr, PAGE_SIZE)
>
> ?
>
> afaict ALIGN() tries to do the right thing, and if it doesn't, we
> should fix ALIGN().
>
That should do the right thing, provided there are no duplicate ALIGN defintions
elsewhere
kernel.h has
#define ALIGN(x,a) __ALIGN_MASK(x,(typeof(x))(a)-1)
#define __ALIGN_MASK(x,mask) (((x)+(mask))&~(mask))
Which seems like the correct thing, since we use typeof(x) for (a) - 1.
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-06-12 6:13 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 15:29 [-mm][PATCH 0/4] Add memrlimit controller (v5) Balbir Singh
2008-05-21 15:29 ` [-mm][PATCH 1/4] Add memrlimit controller documentation (v5) Balbir Singh
2008-05-22 4:16 ` Andrew Morton
2008-05-22 10:13 ` Balbir Singh
2008-05-21 15:29 ` [-mm][PATCH 2/4] Setup the memrlimit controller (v5) Balbir Singh
2008-05-22 4:18 ` Andrew Morton
2008-05-22 10:14 ` Balbir Singh
2008-06-11 17:10 ` Andrea Righi
2008-06-11 17:33 ` Balbir Singh
2008-06-11 18:48 ` Andrea Righi
2008-06-11 19:15 ` Andrew Morton
2008-06-11 20:17 ` Andrea Righi
2008-06-11 20:43 ` Andrew Morton
2008-06-11 22:47 ` Andrea Righi
2008-06-11 22:55 ` Andrew Morton
2008-06-11 23:04 ` Andrea Righi
2008-06-12 6:13 ` Balbir Singh [this message]
2008-06-12 8:52 ` Andrea Righi
2008-06-12 9:02 ` Andrew Morton
2008-06-12 9:12 ` Andrea Righi
2008-06-12 17:02 ` [PATCH -mm] PAGE_ALIGN(): correctly handle 64-bit values on 32-bit architectures Andrea Righi
2008-06-12 22:14 ` Andrea Righi
2008-06-13 9:37 ` Balbir Singh
2008-06-13 9:45 ` Li Zefan
2008-05-21 15:29 ` [-mm][PATCH 3/4] cgroup mm owner callback changes to add task info (v5) Balbir Singh
2008-05-22 4:19 ` Andrew Morton
2008-05-22 10:14 ` Balbir Singh
2008-05-21 15:30 ` [-mm][PATCH 4/4] Add memrlimit controller accounting and control (v5) Balbir Singh
2008-05-21 17:20 ` Vivek Goyal
2008-05-22 4:41 ` Balbir Singh
2008-05-22 4:24 ` Andrew Morton
2008-05-22 10:15 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4850BE9B.5030504@linux.vnet.ibm.com \
--to=balbir@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
--cc=righi.andrea@gmail.com \
--cc=skumar@linux.vnet.ibm.com \
--cc=xemul@openvz.org \
--cc=yamamoto@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).