Re: [PATCH] kmemtrace: SLUB hooks for caller-tracking functions.

Pekka Enberg
2008-09-01T07:16:49Z

Eduard - Gabriel Munteanu wrote:
> On Sun, Aug 31, 2008 at 05:35:40PM +0300, Pekka Enberg wrote:
>> Eduard - Gabriel Munteanu wrote:
>>> This patch adds kmemtrace hooks for __kmalloc_track_caller() and
>>> __kmalloc_node_track_caller(). Currently, they set the call site pointer
>>> to the value recieved as a parameter. (This could change if we implement
>>> stack trace exporting in kmemtrace.)
>>> Signed-off-by: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
>> Applied. I had to do some manual tweaking, so can you please double-check
>> the result:
>>
>> http://git.kernel.org/?p=linux/kernel/git/penberg/slab-2.6.git;a=commitdiff;h=b9f1ecc6428f0ba391845b2ac7df8618da287e4f
>>
>> Thanks!
>
> Looks fine to me. However, you can now remove the casts to unsigned long
> from 'caller', i.e. "s/(unsigned long) caller/caller/g"

Fixed, thanks!