From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4F3A5606A323 for ; Fri, 30 Oct 2026 11:15:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=X0Z5bJ43 Received: by kanga.kvack.org (Postfix) id 391EB6B05B4; Fri, 30 Oct 2026 07:15:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 341A96B05B7; Fri, 30 Oct 2026 07:15:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E3006B05B8; Fri, 30 Oct 2026 07:15:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id F0BD36B05B4 for ; Fri, 30 Oct 2026 07:15:40 -0400 (EDT) Received: from smtpin24.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E340912061B for ; Fri, 30 Oct 2026 11:15:39 +0000 (UTC) X-FDA: 85379037198.24.B5CFDB0 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf16.hostedemail.com (Postfix) with ESMTP id 3214318000E for ; Fri, 30 Oct 2026 11:15:38 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=X0Z5bJ43; spf=pass (imf16.hostedemail.com: domain of david@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1793358938; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jcFVnDvIZ8heZvYaiF3eCzfDTR74GY+V/2n+TMcTvAs=; b=CvywTZFyFaryFIC8iF1p2vEyqWRWg1OH06KfsS8Njhpzu+lf348b9gUpjvq2vQ/Kw//dvE 5mfAAIx6m7cSGtq/6e2yg1uHrxh9VeXv75UEIZqywsHZ8uJpBenor8+VsS/wRwALfWbKyU 0esXA5BUxWWRrhUEDDfPxJnfDSkmthI= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=X0Z5bJ43; spf=pass (imf16.hostedemail.com: domain of david@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; d=hostedemail.com; s=arc-20220608; cv=none; t=1793358938; b=iRikYzZPINjRfkl7yXv0Ncvnku4lZXrTuiSfhPsDColf2pYcc/6RFGMiQT62Nk0bdtv1e3 TN0bOWDMuy4JUq2Ke+Yyvf1E3cGiZjEhoWO56F2S+2h90U+9G1euD9fwVx4JGm0tA8UfPW 5eWhvCqTxSAsNzwsn+s4WDohB1vVMnM= Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 6C028605D0; Fri, 30 Oct 2026 11:15:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9548D1F000C1; Fri, 30 Oct 2026 11:15:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793358937; bh=jcFVnDvIZ8heZvYaiF3eCzfDTR74GY+V/2n+TMcTvAs=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=X0Z5bJ43M9j+dsxw0EOfb2RfVAPvTOOq7wzfRja5C/mo0S5QFye2IEgPAlORI4c3g ifImjUhJwdI8WKJ5YsmZzwNO9T/m0kviNcNKqqlF1HggGNZPwAWIf5tuKcs2oU5XVz izKsKdkgcOFL5wt8C5/w8BeHHulb+7ldzTHu+6qfcHg6P136wlJ4Zt/a0lQGMSi3hY KM0nA2fT0xAsx3g4kOpikLMdyV+GVhDasUmL3YTRLy61zlRQukgrzzF1OnpaAKinvF CdRbd2dFS6Ly6QcLF/O4Pob9/Zy+lYtZgiUY62l/mQIs9T+8HMZdWboQ0mM+HSpbiP UY5gtheZjBa1w== Message-ID: <48a66134-3522-4b81-adca-4e76d52dc391@kernel.org> Date: Fri, 30 Oct 2026 12:15:19 +0100 X-Archived-By: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 27/47] mm/mmu_gather: fix flushing ranges with 4 GiB or larger To: SJ Park Cc: Johannes Weiner , Michal Hocko , Qi Zheng , Shakeel Butt , Lorenzo Stoakes , Kairui Song , Barry Song , Axel Rasmussen , Yuanchu Xie , Wei Xu , Baoquan He , Baolin Wang , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Kees Cook , Peter Zijlstra , Jann Horn , Pedro Falcato , Hugh Dickins , Pasha Tatashin , Pratyush Yadav , "Matthew Wilcox (Oracle)" , Jan Kara , Zi Yan , Lance Yang , Rik van Riel , Harry Yoo , Alistair Popple , Nico Pache , Ryan Roberts , Dev Jain , Usama Arif , Kiryl Shutsemau , Matthew Brost , John Hubbard , Peter Xu , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Oscar Salvador , Minchan Kim , Muchun Song , Xu Xin , Chengming Zhou , Chris Li , Kemeng Shi , Nhat Pham , Youngjun Park , Gregory Price , Joshua Hahn , Rakie Kim , Ying Huang , Jason Gunthorpe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kexec@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-cxl@vger.kernel.org, Josef Bacik , stable@vger.kernel.org References: <20261030005726.155279-1-sj@kernel.org> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <20261030005726.155279-1-sj@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 3214318000E X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=4.0.1 X-Stat-Signature: otx3zfbmxwzdzx36g6o9e8sxhdoh7qru X-HE-Tag: 1793358938-98931 X-HE-Meta: U2FsdGVkX1/goIfja09MfGkibmogTkn4uoBP+sIEW/Tcx3bzW7IBsU/T92zcgqBmT7trlF5BENKfmCZ2ON58fdD7Yux5s29bTZZZaSkV3xzMEN5P9X6zw8/+qoQUsQhTnj5CTktD0B1UgCLek6aOYxrBw4KAIDE4xLGT404H+KNIvimow2Rgq/w6p0SMzB5Q0MXDXOViqoE+veyl55niuKiSG4zucpj+ImDCJFQbX1noOcjH6JH7rksLuZQIxJ9pQBoHi+mGjtg9C7VaRxF1yJcoULhe4SmkzfUABoInzzhiEp1N5GZrlfrI2FHpejohAPFLyP3izDjhKsfLqCQrJ6pnnF5C3BEiPU62Ahy3hTlfwMO51WMgdPQwh/xu160cCODzCFKMwp3qbwlsf/d1Ofvw0nRs+KCrgDuK5yzJtdhzVmt/0cNBFK6BenYGJ2tCxAHo/4J+aPpM0K/PXJHohCkWJjoxPlNrrYUJBMGPLiQKRutZZblI9iGybJrNsNRRibkzXXRNdNdyHU4Ct6QFcPll+ujr7uRyiYpi6MacZaNVDxYvryJhKI8ylwXAo2Dbac1Fk4MR+kSPiBWO2qjccK+bQ6P++j8dDU0UvJ7/mQYOXm0tT/YQsjV1hZpjP8KUptIk91zy7DEkorcsHidz2rlMqzM77+YAncf9avt27/+uQe9XoVAYpLWx9+LrwwqpSl35eD8sOaPMNJw6SPa0lGGzYczRIVTm9TAzMqgmwDLkmm/KMPhyBTiEnF+cqoHlR7ZIhyYaZYwV9LqUt2C3Anl5/xBXnduBH4ZJBB8fgpvREA6Ntp10Vj7TQ2JhsqXeumacuKNISp7JlQ3jWCJrRC87JeO8Kfrsb9wRs6Hr/uRyXEsZId6T2sVElcv9Kh3H3uCQYWRtYiEqHxu0D+GePRVgVde8RCaJxBJykmvR1dEYCcP0SuvZ8C4MViX93Vv1xp5yiGXYUtyvo0WkDVa gBRrrrlf eDmKH3AtOYoTnEUGxuHtDppCQvU9sC1Y1og1mdNvNXtivgwLzxOwvC+1R+6qkXlO/4t7qtTrU8EeYT/6w1j9Nc0JnOOaWHozXcVEqsbMve5LU6L3vrzsT69kw8a0uedM17CetDZm1k9G+EZZcg/6LRj1I8oEP/b1muQj+ei3yq/0ag+OC3Nht7waHVSYPSjJvU1Doaxf9peq6/rrUaOrVBrIEGpYhvHH2mO1i03vMTjJtauCNVGaanYg/ecx+bqsGBAvRKQ60dMnKQz2wXH+Co9iI3lwc9dcMOwfSqHl03EPbkV6qCb1yMLKXAdg3g0qEjHIqVK+n3HCh3tODsA3zgZvcNGALKiPLhJYCs7MXMiNMFFBoKESNmknV/UzaloFnQTiRBPuEZ6+4RL1/SplWnhVZpU2V4ek7kg1ksXyu4+jqrHQOUezyEflH383gUbsAgYoBYfRWu3Io/3AePCuJMqMIeaVXUwXwRerQDVUE3zmu0mbP/VE8Pm71Td3w1JzbdTTYTFTvjvVd7MZsXnlu8hAXc6+dIcWZUHTcgiWqLz4fOHORtaG9x68IfrPMu0FUmBAX+oq/Q8QdRi8= Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On 10/30/26 01:57, SJ Park wrote: > On Thu, 29 Oct 2026 21:33:22 +0100 "David Hildenbrand (Arm)" wrote: > >> From: Josef Bacik >> >> __tlb_adjust_range() takes the size of the range which has to be flushed >> as an unsigned int. Its callers, tlb_flush_{pte,pmd,pud,p4d}_range(), get >> and pass an unsigned long. Consequently, a range that is 4 GiB or larger >> gets truncated, possibly to 0. >> >> On arm64 with hugetlb, a 64k kernel can have 16 GiB hugetlb folios >> mapped contiguously at the PMD level and flush them when unmapping, and a >> 16k kernel can flush 64 GiB PUDs through tlb_unshare_pmd_ptdesc(). So >> at least these two scenarios are affected. >> >> Fix it by flushing the proper range instead of the truncated one by >> properly using "unsigned long" for range_size. > > Makes sense to me. > >> >> Fix generated by an LLM and sent by Josef Bacik in private. >> >> Fixes: b528e4b6405b ("mm/hugetlb: add tlb_remove_hugetlb_entry for handling hugetlb pages") >> Fixes: 8ce720d5bd91 ("mm/hugetlb: fix excessive IPI broadcasts when unsharing PMD tables using mmu_gather") >> Cc: stable@vger.kernel.org >> Signed-off-by: Josef Bacik >> Acked-by: Lorenzo Stoakes (ARM) >> [ david: use two-tab indent, simplify description ] > > It seems the convention [1] is to put the above modification note right before > the last S-o-b: of David. Maybe you forgot moving it after adding R-b: and > T-b: from great reviewers? It's "b4 trailers" that apparently messes this up. I don't think it really matters (some move it above all trailers), but I'll fix this up when applying. (++ on all the great people around here) > >> Reviewed-by: Qi Zheng >> Reviewed-by: Gregory Price (Meta) >> Tested-by: Gregory Price (Meta) >> Reviewed-by: Dev Jain >> Reviewed-by: Muchun Song >> Reviewed-by: Pedro Falcato >> Signed-off-by: David Hildenbrand (Arm) > > Reviewed-by: SJ Park Thanks! -- Cheers, David