From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 770A1C6379F for ; Sat, 11 Feb 2023 08:19:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 977CC6B0078; Sat, 11 Feb 2023 03:19:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 926A96B007B; Sat, 11 Feb 2023 03:19:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7EDB16B007D; Sat, 11 Feb 2023 03:19:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6AD996B0078 for ; Sat, 11 Feb 2023 03:19:01 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D81D01214A6 for ; Sat, 11 Feb 2023 08:19:00 +0000 (UTC) X-FDA: 80454310440.10.AC21F86 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by imf08.hostedemail.com (Postfix) with ESMTP id F3F4116000D for ; Sat, 11 Feb 2023 08:18:58 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=PHWRqsM2; spf=pass (imf08.hostedemail.com: domain of bagasdotme@gmail.com designates 209.85.216.54 as permitted sender) smtp.mailfrom=bagasdotme@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676103539; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f5Y2IOJ6Y1jzGi1sXY9QnheXqq2KoQrWJa2bEZkQXhM=; b=8juSS62HXu0XWJ7ecPTyyDCqDv7AecAZ9Z9VFo1VblIu6F2RIZUPKYs/opQCtD9fH9qJtJ QHxj3BxHxaUjdm6NI6Pd8mY6Unhy1wEJSIYvwr7FKipoIazMWj5UDAXE2OeQ4PqFEJHBBa e9OZmmrTYcOfDWm8xLIbAnT6U2Hg1kY= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=PHWRqsM2; spf=pass (imf08.hostedemail.com: domain of bagasdotme@gmail.com designates 209.85.216.54 as permitted sender) smtp.mailfrom=bagasdotme@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676103539; a=rsa-sha256; cv=none; b=NsjQ3V2ufceOQ39LIP/x+yTXYm/7ZnC7GHW0GpgEIG41ixRuTpTdhVqlzwCWqJwQk+kLln kduRoc6s1wJeSOhSDYIONzpV2JaQcuo38eRm/LGr+YLAp5vfKxwlBSMt/iqbvlcC2RzzHa j1IKbI/7EkwnbSKLDlx8oRX7+xly1ao= Received: by mail-pj1-f54.google.com with SMTP id nn4-20020a17090b38c400b00233a6f118d0so5453730pjb.2 for ; Sat, 11 Feb 2023 00:18:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=f5Y2IOJ6Y1jzGi1sXY9QnheXqq2KoQrWJa2bEZkQXhM=; b=PHWRqsM2t//NUHRQ3OJjcioM2MQNLfcFn0kD/XW0BHs0MrNxxxAylvSg0vH8UAuWSH chxSwFwB/fBdAY3WJz4ZMP3Im0dU2kiUNqGcjVnNFGG46G8Xj7AbE3hyRfA8CKufC7v9 6f96gEPXMVF5FIYImi0MztNbWrOYeit+eUxsTxOrE4cwK+z/p2bY+pQK/ciaPjcoEDhe GKrhKuC+pVf/JCbdIHVlNMPvflxrVpWgHVGiuhlNBtDHWl2WBdK6jexQMd5ygnZb9oyo Mt23WiIKUkZxspDAUZvF2pabUMjljBpuIqeQ3NUu5vHChwj6cXSPT8I5Ehh0LNPZO9Up fuMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=f5Y2IOJ6Y1jzGi1sXY9QnheXqq2KoQrWJa2bEZkQXhM=; b=1ZltzY8MnMz5z2DRcCfk9hskguUmLplxPQELAiCdkYu0srX9I669SsQV1OCzB/2hmO m+JI5j37o2rwdOb0BegSWl2oUzY96cXM0lKna20iEvYUvszs/CJKk+MpODoK1Sne43kR g8pqaRetydmWhEiDf1PSH5CJ2OWY9mCns3hk3EbHNK393GEuO9AECjS6mHGqzlZrnyxi y0roiJ0HZXvTOYrXlB25Jy80Jjilh22YK8F98IExsVGM3odI9UlLyjg3dWxboclD7XVC W6tZvqwhLYiONHashAZliKKZspMI3Rb1hiKGXquf5vJK+rDlcg99gisawV0pJSnrzsmB lOXg== X-Gm-Message-State: AO0yUKWCmGd/GpZiPYpiaE0NCgVBxehOLNE62mihiobizczM3GEK2kCy 0NujZpeieT3YAShhqqMgtWw= X-Google-Smtp-Source: AK7set8l4vNHP7jm4zzR0JmMhos4cGV/JAr7ZGeAuHUuOPKPQGTkzCR/W7ftgqZwSOwAOd85Wi4siw== X-Received: by 2002:a17:902:eb83:b0:198:f45c:853c with SMTP id q3-20020a170902eb8300b00198f45c853cmr9630060plg.25.1676103537911; Sat, 11 Feb 2023 00:18:57 -0800 (PST) Received: from [192.168.43.80] (subs32-116-206-28-35.three.co.id. [116.206.28.35]) by smtp.gmail.com with ESMTPSA id b10-20020a1709027e0a00b001994fc55998sm4429585plm.217.2023.02.11.00.18.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Feb 2023 00:18:57 -0800 (PST) Message-ID: <48c904ba-cb25-dc55-4ea1-a5efcdcd8c34@gmail.com> Date: Sat, 11 Feb 2023 15:18:53 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [RFC PATCH v2 14/19] docs: document new procfs ksm knobs Content-Language: en-US To: Stefan Roesch , kernel-team@fb.com Cc: linux-mm@kvack.org, riel@surriel.com, mhocko@suse.com, david@redhat.com, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, akpm@linux-foundation.org References: <20230210215023.2740545-1-shr@devkernel.io> <20230210215023.2740545-15-shr@devkernel.io> From: Bagas Sanjaya In-Reply-To: <20230210215023.2740545-15-shr@devkernel.io> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: udbukgkjqmopo9cwpxwocesu18nygd5m X-Rspamd-Queue-Id: F3F4116000D X-HE-Tag: 1676103538-72978 X-HE-Meta: U2FsdGVkX1+6kPBzZMLwhiBZe9Z6AQSIy4WWSv0pU+1JNv0MtX9HhGeFM5I8HibFv5hVauqtU70Ha7BfxQ4zJ5mDZ976UjpUDwFcAENkZoOuZT0SvPz2cFdh9DM0nXeSIeJduaVUT3DnIBSM5w24FiovcrL6MW1fSGKUoSnaXzllit/I8SZpMqc9kfLTfDazurXxdtIA9tv4nM5+oyrGxJ71S7ZhMyhY1oedcaAqfa0YSwAIcm7ELeRSpdp4v6InC2TdZXgi9zz8s9lgCebTGP2UABJzla1d1sam2TlkSQhkg94anJbyUzmejH/O63g19dCbMBuTzBpTtDDYtj1A0K/DX7L1IWuTdosrZh4n2in4PiafE7lZ+5aldofmmCzbOricu16kodjaCCLAYcd4Jqgpj89EiRrub7+Sy0EzOD3vO/EtmFkf88HiJQ+nicyx9aIViDttHpos3evp2O5I7EFv+KPTHqwP128l/TMrS1MDfYNubO487XNK7nhP1+D8AdO/VK0c5Cl5I0LJEopxhFsFjxmFggkryXZ/9TbxX4MX8NIR3i+4oTJ0ULqFZjNqRhJdYuIHfoU8WrUZBh5YrA5Hsa+h9bCcVspLhYZGqfUR689lDAvukGxUWNqFQNJiuDT+6e4qNDnU6Nk5uiQcJ+zOw8MdurWs4OPlxfsVBkxfMjYcXJWH3lOEUiiVpeGUruVJBi/5xb8KMTf952uuvX0tQaYZkJQMPWEEw62j1MoySDUfDpHkFnPQ/LbGEHETn0PF4pOuca+iAiWP0ZDISkYvY8SwZSm50TxXlprch4Z67whUjFBreyK2W8gaixAKrZzT8r3Astszl1cROuthqicCL5nikpqwYTTu/BC+vE/JCTGrHygmydnnMU9YG7bhbzEs0RuoznYH9Ig+Tjc3RxpOuRLEc02yYPXpUSPW/pi3UZLt/a0pMVqTmAdMbtUAWi6K6bmMdj8QaIfYt/V XB/XzMUR +vOvJi6Ski5A81LXnsEv/kY+yEfBYJx3mTOFlQGgaYI+JGo5aityuoGv93aZ6kATioF8PkbWHyt+YGcV5/UJw7hrZsfXd4W+FhD7YAkKj97wZnzdhDZrto8msHYUjNZyGgNUgLsbxudcHAstgBqmAcu5uc9agnzyxkp/E5lpJUdSh3JbJhj/2dpF2WkH0ogM1FaKNYmuj0l1XfFxlDD5Hl+8ubdAJv8I+KwK7+DA19VimXT9qmZ4j4IR6p6Y6EdynqFdgeDzRBYFV4XNKwAbK46YsHi94FjqQ8uDjwMRJLIEjW8aGKexphnYfznE0GVGdxeh4PUJOBR1yun1qznXiNL1Gfc/g5/xksv2dzn2sjqQ/9WzPVThumj7pYRzwhx6byUeqVeTTf+lnsAUsYgQScIoxc77CNVM5JvbNbQ/1s24YcN0fvTsa9ZVRt77B+UgWo4MgycuUI/Vhlx+wx1oTC7I2uw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000021, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/11/23 04:50, Stefan Roesch wrote: > diff --git a/Documentation/admin-guide/mm/ksm.rst b/Documentation/admin-guide/mm/ksm.rst > index 5c4daf44d79d..34f1d0396eee 100644 > --- a/Documentation/admin-guide/mm/ksm.rst > +++ b/Documentation/admin-guide/mm/ksm.rst > @@ -218,7 +218,8 @@ several times, which are unprofitable memory consumed. > ksm_rmap_items * sizeof(rmap_item). > > where ksm_merging_pages is shown under the directory ``/proc//``, > - and ksm_rmap_items is shown in ``/proc//ksm_stat``. > + and ksm_rmap_items is shown in ``/proc//ksm_stat``. The process profit > + is also shown in ``/proc//ksm_stat`` as ksm_process_profit. > > From the perspective of application, a high ratio of ``ksm_rmap_items`` to > ``ksm_merging_pages`` means a bad madvise-applied policy, so developers or > @@ -229,6 +230,9 @@ so if the ``ksm_rmap_items/ksm_merging_pages`` ratio exceeds 64 on 64-bit CPU > or exceeds 128 on 32-bit CPU, then the app's madvise policy should be dropped, > because the ksm profit is approximately zero or negative. > > +The ksm_merge_type in ``/proc//ksm_stat`` shows the merge type of the > +process. Valid values are ``none``, ``madvise`` and ``process``. > + > Monitoring KSM events > ===================== > LGTM, thanks! Reviewed-by: Bagas Sanjaya -- An old man doll... just what I always wanted! - Clara