Re: [PATCH] memory hotplug: fix page_zone() calculation in test_pages_isolated()

Nathan Fontenot
2008-10-29T18:00:39Z

Looks like you beat me to it, and with a nicer fix too.

Gerald Schaefer wrote:
> From: Gerald Schaefer <gerald.schaefer@de.ibm.com>
>
> My last bugfix here (adding zone->lock) introduced a new problem: Using
> page_zone(pfn_to_page(pfn)) to get the zone after the for() loop is wrong.
> pfn will then be >= end_pfn, which may be in a different zone or not
> present at all. This may lead to an addressing exception in page_zone()
> or spin_lock_irqsave().
>
> Now I use __first_valid_page() again after the loop to find a valid page
> for page_zone().
>
> Signed-off-by: Gerald Schaefer <gerald.schaefer@de.ibm.com>

Acked-by: Nathan Fontenot <nfont@austin.ibm.com>