From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <491A0A8F.30805@redhat.com> Date: Wed, 12 Nov 2008 00:43:27 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [PATCH 3/4] add ksm kernel shared memory driver References: <1226409701-14831-1-git-send-email-ieidus@redhat.com> <1226409701-14831-2-git-send-email-ieidus@redhat.com> <1226409701-14831-3-git-send-email-ieidus@redhat.com> <1226409701-14831-4-git-send-email-ieidus@redhat.com> <20081111150345.7fff8ff2@bike.lwn.net> In-Reply-To: <20081111150345.7fff8ff2@bike.lwn.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Jonathan Corbet Cc: Izik Eidus , linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org, aarcange@redhat.com, chrisw@redhat.com List-ID: Jonathan Corbet wrote: >> +static struct list_head slots; >> > > Some of these file-static variable names seem a little..terse... > While ksm was written to be independent of a certain TLA-named kernel subsystem developed two rooms away, they share some naming... this refers to kvm 'memory slots' which correspond to DIMM banks. I guess it should be renamed to merge_ranges or something. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org