From: "zhen.ni" <zhen.ni@easystack.cn>
To: Zi Yan <ziy@nvidia.com>, akpm@linux-foundation.org, vbabka@kernel.org
Cc: surenb@google.com, mhocko@suse.com, jackmanb@google.com,
hannes@cmpxchg.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v11 2/4] mm/page_owner: add NUMA node filter
Date: Fri, 26 Jun 2026 16:20:43 +0800 [thread overview]
Message-ID: <4944753a-da93-4f7a-8f22-81bf41cd171a@easystack.cn> (raw)
In-Reply-To: <DJICJHL8QY2F.2C6UR95O4RBIT@nvidia.com>
在 2026/6/26 02:37, Zi Yan 写道:
>> + nid = memdesc_nid(page_flags);
>> + if (!node_isset(nid, state->nid_filter)) {
>> + spin_unlock_irqrestore(&state->lock, flags);
>> + goto ext_put_continue;
>> + }
>> + }
>> + spin_unlock_irqrestore(&state->lock, flags);
>> +
>> /* Record the next PFN to read in the file offset */
>> *ppos = pfn + 1;
>>
>> @@ -783,6 +807,7 @@ read_page_owner(struct file *file, char __user *buf, size_t count, loff_t *ppos)
>> &page_owner_tmp, handle, state);
>> ext_put_continue:
>> page_ext_put(page_ext);
>> + cond_resched();
> In the changelog above, cond_resched() is said to be removed in V10. Did
> you miss this? Or it is intended.
>
Sorry. This is a changelog error in v10.
The v10 changelog wording is misleading. It should say:
"Remove need_resched() check, call cond_resched() unconditionally"
> Otherwise, LGTM.
>
> Acked-by: Zi Yan<ziy@nvidia.com>
next prev parent reply other threads:[~2026-06-26 8:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-25 4:30 [PATCH v11 0/4] mm/page_owner: add per-fd filter infrastructure for print_mode and NUMA filtering Zhen Ni
2026-06-25 4:30 ` [PATCH v11 1/4] mm/page_owner: add print_mode filter Zhen Ni
2026-06-25 18:26 ` Zi Yan
2026-06-25 19:20 ` Andrew Morton
2026-06-25 19:24 ` Zi Yan
2026-06-25 4:30 ` [PATCH v11 2/4] mm/page_owner: add NUMA node filter Zhen Ni
2026-06-25 18:37 ` Zi Yan
2026-06-26 8:20 ` zhen.ni [this message]
2026-06-25 19:27 ` Zi Yan
2026-06-25 20:04 ` Andrew Morton
2026-06-25 4:31 ` [PATCH v11 3/4] tools/mm: add page_owner_filter userspace tool Zhen Ni
2026-06-25 4:50 ` Andrew Morton
2026-06-25 4:31 ` [PATCH v11 4/4] mm/page_owner: document page_owner filter Zhen Ni
2026-06-25 4:55 ` [PATCH v11 0/4] mm/page_owner: add per-fd filter infrastructure for print_mode and NUMA filtering Andrew Morton
2026-06-25 12:57 ` zhen.ni
2026-06-25 18:22 ` Zi Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4944753a-da93-4f7a-8f22-81bf41cd171a@easystack.cn \
--to=zhen.ni@easystack.cn \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=jackmanb@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox