From: Li Zefan <lizf@cn.fujitsu.com>
To: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kamezawa.hiroyu@jp.fujitsu.com, balbir@linux.vnet.ibm.com,
menage@google.com
Subject: Re: [RFC][PATCH 1/4] memcg: fix for mem_cgroup_get_reclaim_stat_from_page
Date: Fri, 09 Jan 2009 08:57:59 +0800 [thread overview]
Message-ID: <4966A117.9030201@cn.fujitsu.com> (raw)
In-Reply-To: <20090108191430.af89e037.nishimura@mxp.nes.nec.co.jp>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index e2996b8..62e69d8 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -559,6 +559,10 @@ mem_cgroup_get_reclaim_stat_from_page(struct page *page)
> return NULL;
>
> pc = lookup_page_cgroup(page);
> + smp_rmb();
It is better to add a comment to explain this smp_rmb. I think it's recommended
that every memory barrier has a comment.
> + if (!PageCgroupUsed(pc))
> + return NULL;
> +
> mz = page_cgroup_zoneinfo(pc);
> if (!mz)
> return NULL;
>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-01-09 0:58 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-08 10:08 [RFC][PATCH 0/4] some memcg fixes Daisuke Nishimura
2009-01-08 10:14 ` [RFC][PATCH 1/4] memcg: fix for mem_cgroup_get_reclaim_stat_from_page Daisuke Nishimura
2009-01-08 10:59 ` [RFC][PATCH 1/4] memcg: fix formem_cgroup_get_reclaim_stat_from_page KAMEZAWA Hiroyuki
2009-01-09 0:57 ` Li Zefan [this message]
2009-01-09 1:05 ` [RFC][PATCH 1/4] memcg: fix for mem_cgroup_get_reclaim_stat_from_page KAMEZAWA Hiroyuki
2009-01-09 2:34 ` Daisuke Nishimura
2009-01-09 2:41 ` KAMEZAWA Hiroyuki
2009-01-09 4:32 ` Balbir Singh
2009-01-09 4:47 ` KAMEZAWA Hiroyuki
2009-01-15 11:08 ` [PATCH] mark_page_accessed() in do_swap_page() move latter than memcg charge KOSAKI Motohiro
2009-01-15 11:12 ` KAMEZAWA Hiroyuki
2009-01-15 11:30 ` Balbir Singh
2009-01-15 12:07 ` Hugh Dickins
2009-01-15 12:28 ` KAMEZAWA Hiroyuki
2009-01-15 13:34 ` KOSAKI Motohiro
2009-01-15 13:43 ` KOSAKI Motohiro
2009-01-08 10:14 ` [RFC][PATCH 2/4] memcg: fix error path of mem_cgroup_move_parent Daisuke Nishimura
2009-01-08 11:00 ` KAMEZAWA Hiroyuki
2009-01-09 5:15 ` Balbir Singh
2009-01-09 5:33 ` Daisuke Nishimura
2009-01-09 6:01 ` Balbir Singh
2009-01-08 10:15 ` [RFC][PATCH 3/4] memcg: fix for mem_cgroup_hierarchical_reclaim Daisuke Nishimura
2009-01-08 11:08 ` KAMEZAWA Hiroyuki
2009-01-09 1:08 ` KAMEZAWA Hiroyuki
2009-01-09 2:51 ` Daisuke Nishimura
2009-01-09 3:09 ` KAMEZAWA Hiroyuki
2009-01-09 5:34 ` Balbir Singh
2009-01-09 5:33 ` Balbir Singh
2009-01-09 6:01 ` Daisuke Nishimura
2009-01-09 9:01 ` Daisuke Nishimura
2009-01-08 10:15 ` [RFC][PATCH 4/4] memcg: make oom less frequently Daisuke Nishimura
2009-01-08 11:19 ` KAMEZAWA Hiroyuki
2009-01-09 1:44 ` Daisuke Nishimura
2009-01-09 2:03 ` KAMEZAWA Hiroyuki
2009-01-09 2:29 ` Daisuke Nishimura
2009-01-09 2:39 ` KAMEZAWA Hiroyuki
2009-01-09 5:58 ` Balbir Singh
2009-01-09 8:52 ` Daisuke Nishimura
2009-01-09 9:03 ` Balbir Singh
2009-01-09 9:37 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4966A117.9030201@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=balbir@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=menage@google.com \
--cc=nishimura@mxp.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).