From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 526B9C4727E for ; Thu, 1 Oct 2020 18:36:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AFE5720780 for ; Thu, 1 Oct 2020 18:36:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="SVSRLLag" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AFE5720780 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EC9A26B0068; Thu, 1 Oct 2020 14:36:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E77C16B0074; Thu, 1 Oct 2020 14:36:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D40436B0078; Thu, 1 Oct 2020 14:36:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0156.hostedemail.com [216.40.44.156]) by kanga.kvack.org (Postfix) with ESMTP id A33C36B0068 for ; Thu, 1 Oct 2020 14:36:42 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 393C23620 for ; Thu, 1 Oct 2020 18:36:42 +0000 (UTC) X-FDA: 77324212644.02.books69_1802f762719d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id 119CE10038E2A for ; Thu, 1 Oct 2020 18:36:42 +0000 (UTC) X-HE-Tag: books69_1802f762719d X-Filterd-Recvd-Size: 5075 Received: from hqnvemgate24.nvidia.com (hqnvemgate24.nvidia.com [216.228.121.143]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Thu, 1 Oct 2020 18:36:41 +0000 (UTC) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Thu, 01 Oct 2020 11:34:55 -0700 Received: from [10.2.56.62] (172.20.13.39) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 1 Oct 2020 18:36:26 +0000 Subject: Re: [PATCH 1/5] kselftests: vm: Add mremap tests To: Kalesh Singh CC: Suren Baghdasaryan , Minchan Kim , Joel Fernandes , Lokesh Gidra , "Cc: Android Kernel" , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , Borislav Petkov , the arch/x86 maintainers , "H. Peter Anvin" , Andrew Morton , Shuah Khan , Aneesh Kumar K.V , Kees Cook , Peter Zijlstra , Sami Tolvanen , Arnd Bergmann , Masahiro Yamada , Frederic Weisbecker , "Krzysztof Kozlowski" , Hassan Naveed , Christian Brauner , Mark Rutland , Mike Rapoport , Gavin Shan , Dave Martin , Jia He , Zhenyu Ye , Jason Gunthorpe , Zi Yan , Mina Almasry , "Kirill A. Shutemov" , Ram Pai , "Sandipan Das" , Dave Hansen , "Ralph Campbell" , Brian Geffon , "Masami Hiramatsu" , Ira Weiny , "SeongJae Park" , LKML , "moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)" , "open list:MEMORY MANAGEMENT" , "open list:KERNEL SELFTEST FRAMEWORK" References: <20200930222130.4175584-1-kaleshsingh@google.com> <20200930222130.4175584-2-kaleshsingh@google.com> <0dc41856-e406-7f00-1eb9-5e97e476afa4@nvidia.com> From: John Hubbard Message-ID: <49725bf8-edde-0773-ade3-6e2d0d380b34@nvidia.com> Date: Thu, 1 Oct 2020 11:36:25 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1601577295; bh=+axEu1nAHGxA0oIj2posZvrjhKpFm9z+hbO8+osX2cM=; h=Subject:To:CC:References:From:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Language: Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy; b=SVSRLLag8GZsw+5UJWjx1u1jyED7zf0FtWS3W1mXT56gGlqTnHFmfT6dsd4e+8760 gtYhpvBcEkptDZraHA7d+dQ1W9zh/zrpoiZ+oq75pJaY8onT6DuL8s5qC6ni83zvri 2+zYJq6i3RhzBB6Z1OXZntINHvB30GsBzUsgUu/RT6nS1jOZNk3C6Zz1F2I1PpLORJ Qei7MJqa6RWx+JsjoE7wQgdQ77IiZn/oBM4fEaJWZWh21CIn4vvC3sdpeSX13qQlso Zb1RzUfagrBy9IOK23W23toFZjdlyWAQGemUpjQZ7VjfMsPVyZ00q1lBkdSD9urZam Up15lsr+kKwJg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/1/20 8:46 AM, Kalesh Singh wrote: > On Thu, Oct 1, 2020 at 3:24 AM John Hubbard wrote: >> On 9/30/20 3:21 PM, Kalesh Singh wrote: ... > The bulk of the test time comes from setting and verifying the byte > pattern in 1GB > or larger regions for testing the HAVE_MOVE_PUD functionality. Without testing > 1GB or larger regions the test takes 0.18 seconds on my x86_64 system. > > One option I think would be to only validate to a certain threshold of the remap > region. We can have a flag to specify a threshold or to validate the > full size of the > remapped region. I did some initial testing with a 4MB threshold and > the total time > dropped to 0.38 seconds from 1:12 minutes (for verifying the entire > remapped region). > The 4MB threshold would cover the full region of all the tests > excluding those for the > 1GB and 2GB sized regions. Let me know what you think. > That sounds beautiful. thanks, -- John Hubbard NVIDIA