From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Mel Gorman <mel@csn.ul.ie>
Cc: Linux Memory Management List <linux-mm@kvack.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Christoph Lameter <cl@linux-foundation.org>,
Nick Piggin <npiggin@suse.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lin Ming <ming.m.lin@intel.com>,
Zhang Yanmin <yanmin_zhang@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 03/25] Do not check NUMA node ID when the caller knows the node is valid
Date: Tue, 21 Apr 2009 09:00:09 +0300 [thread overview]
Message-ID: <49ED60E9.4030005@cs.helsinki.fi> (raw)
In-Reply-To: <1240266011-11140-4-git-send-email-mel@csn.ul.ie>
Mel Gorman wrote:
> Callers of alloc_pages_node() can optionally specify -1 as a node to mean
> "allocate from the current node". However, a number of the callers in fast
> paths know for a fact their node is valid. To avoid a comparison and branch,
> this patch adds alloc_pages_exact_node() that only checks the nid with
> VM_BUG_ON(). Callers that know their node is valid are then converted.
>
> Signed-off-by: Mel Gorman <mel@csn.ul.ie>
> Reviewed-by: Christoph Lameter <cl@linux-foundation.org>
Reviewed-by: Pekka Enberg <penberg@cs.helsinki.fi>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-04-21 6:04 UTC|newest]
Thread overview: 105+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-20 22:19 [PATCH 00/25] Cleanup and optimise the page allocator V6 Mel Gorman
2009-04-20 22:19 ` [PATCH 01/25] Replace __alloc_pages_internal() with __alloc_pages_nodemask() Mel Gorman
2009-04-21 1:44 ` KOSAKI Motohiro
2009-04-21 5:55 ` Pekka Enberg
2009-04-20 22:19 ` [PATCH 02/25] Do not sanity check order in the fast path Mel Gorman
2009-04-21 1:45 ` KOSAKI Motohiro
2009-04-21 5:55 ` Pekka Enberg
2009-04-20 22:19 ` [PATCH 03/25] Do not check NUMA node ID when the caller knows the node is valid Mel Gorman
2009-04-21 2:44 ` KOSAKI Motohiro
2009-04-21 6:00 ` Pekka Enberg [this message]
2009-04-21 6:33 ` Paul Mundt
2009-04-20 22:19 ` [PATCH 04/25] Check only once if the zonelist is suitable for the allocation Mel Gorman
2009-04-21 3:03 ` KOSAKI Motohiro
2009-04-21 7:09 ` Pekka Enberg
2009-04-20 22:19 ` [PATCH 05/25] Break up the allocator entry point into fast and slow paths Mel Gorman
2009-04-21 6:35 ` KOSAKI Motohiro
2009-04-21 7:13 ` Pekka Enberg
2009-04-21 9:30 ` Mel Gorman
2009-04-21 9:29 ` Mel Gorman
2009-04-21 10:44 ` KOSAKI Motohiro
2009-04-20 22:19 ` [PATCH 06/25] Move check for disabled anti-fragmentation out of fastpath Mel Gorman
2009-04-21 6:37 ` KOSAKI Motohiro
2009-04-20 22:19 ` [PATCH 07/25] Check in advance if the zonelist needs additional filtering Mel Gorman
2009-04-21 6:52 ` KOSAKI Motohiro
2009-04-21 9:47 ` Mel Gorman
2009-04-21 7:21 ` Pekka Enberg
2009-04-21 9:49 ` Mel Gorman
2009-04-20 22:19 ` [PATCH 08/25] Calculate the preferred zone for allocation only once Mel Gorman
2009-04-21 7:03 ` KOSAKI Motohiro
2009-04-21 8:23 ` Mel Gorman
2009-04-21 7:37 ` Pekka Enberg
2009-04-21 8:27 ` Mel Gorman
2009-04-21 8:29 ` Pekka Enberg
2009-04-20 22:19 ` [PATCH 09/25] Calculate the migratetype " Mel Gorman
2009-04-21 7:37 ` KOSAKI Motohiro
2009-04-21 8:35 ` Mel Gorman
2009-04-21 10:19 ` KOSAKI Motohiro
2009-04-21 10:30 ` Mel Gorman
2009-04-20 22:19 ` [PATCH 10/25] Calculate the alloc_flags " Mel Gorman
2009-04-21 9:03 ` KOSAKI Motohiro
2009-04-21 10:05 ` Mel Gorman
2009-04-21 10:12 ` KOSAKI Motohiro
2009-04-21 10:37 ` Mel Gorman
2009-04-21 10:40 ` KOSAKI Motohiro
2009-04-20 22:19 ` [PATCH 11/25] Calculate the cold parameter " Mel Gorman
2009-04-21 7:43 ` Pekka Enberg
2009-04-21 8:41 ` Mel Gorman
2009-04-21 9:07 ` KOSAKI Motohiro
2009-04-21 10:08 ` Mel Gorman
2009-04-21 14:59 ` Christoph Lameter
2009-04-21 14:58 ` Christoph Lameter
2009-04-20 22:19 ` [PATCH 12/25] Remove a branch by assuming __GFP_HIGH == ALLOC_HIGH Mel Gorman
2009-04-21 7:46 ` Pekka Enberg
2009-04-21 8:45 ` Mel Gorman
2009-04-21 10:25 ` Pekka Enberg
2009-04-21 9:08 ` KOSAKI Motohiro
2009-04-21 10:31 ` KOSAKI Motohiro
2009-04-21 10:43 ` Mel Gorman
2009-04-20 22:19 ` [PATCH 13/25] Inline __rmqueue_smallest() Mel Gorman
2009-04-21 7:58 ` Pekka Enberg
2009-04-21 8:48 ` Mel Gorman
2009-04-21 9:52 ` KOSAKI Motohiro
2009-04-21 10:11 ` Mel Gorman
2009-04-21 10:22 ` KOSAKI Motohiro
2009-04-20 22:20 ` [PATCH 14/25] Inline buffered_rmqueue() Mel Gorman
2009-04-21 9:56 ` KOSAKI Motohiro
2009-04-20 22:20 ` [PATCH 15/25] Inline __rmqueue_fallback() Mel Gorman
2009-04-21 9:56 ` KOSAKI Motohiro
2009-04-20 22:20 ` [PATCH 16/25] Save text by reducing call sites of __rmqueue() Mel Gorman
2009-04-21 10:47 ` KOSAKI Motohiro
2009-04-20 22:20 ` [PATCH 17/25] Do not call get_pageblock_migratetype() more than necessary Mel Gorman
2009-04-21 11:03 ` KOSAKI Motohiro
2009-04-21 16:12 ` Mel Gorman
2009-04-22 2:25 ` KOSAKI Motohiro
2009-04-20 22:20 ` [PATCH 18/25] Do not disable interrupts in free_page_mlock() Mel Gorman
2009-04-21 7:55 ` Pekka Enberg
2009-04-21 8:50 ` Mel Gorman
2009-04-21 15:05 ` Christoph Lameter
2009-04-22 0:13 ` KOSAKI Motohiro
2009-04-22 14:43 ` Lee Schermerhorn
2009-04-20 22:20 ` [PATCH 19/25] Do not setup zonelist cache when there is only one node Mel Gorman
2009-04-20 22:20 ` [PATCH 20/25] Do not check for compound pages during the page allocator sanity checks Mel Gorman
2009-04-22 0:20 ` KOSAKI Motohiro
2009-04-22 10:09 ` Mel Gorman
2009-04-22 10:41 ` KOSAKI Motohiro
2009-04-20 22:20 ` [PATCH 21/25] Use allocation flags as an index to the zone watermark Mel Gorman
2009-04-22 0:26 ` KOSAKI Motohiro
2009-04-22 0:41 ` David Rientjes
2009-04-22 10:21 ` Mel Gorman
2009-04-22 10:23 ` Mel Gorman
2009-04-20 22:20 ` [PATCH 22/25] Update NR_FREE_PAGES only as necessary Mel Gorman
2009-04-22 0:35 ` KOSAKI Motohiro
2009-04-20 22:20 ` [PATCH 23/25] Get the pageblock migratetype without disabling interrupts Mel Gorman
2009-04-20 22:20 ` [PATCH 24/25] Re-sort GFP flags and fix whitespace alignment for easier reading Mel Gorman
2009-04-21 8:04 ` Pekka Enberg
2009-04-21 8:52 ` Mel Gorman
2009-04-21 15:08 ` Christoph Lameter
2009-04-21 15:24 ` Mel Gorman
2009-04-20 22:20 ` [PATCH 25/25] Use a pre-calculated value instead of num_online_nodes() in fast paths Mel Gorman
2009-04-21 8:08 ` Pekka Enberg
2009-04-21 9:01 ` Mel Gorman
2009-04-21 15:09 ` Christoph Lameter
2009-04-21 8:13 ` [PATCH 00/25] Cleanup and optimise the page allocator V6 Pekka Enberg
2009-04-22 14:13 ` Mel Gorman
-- strict thread matches above, loose matches on Subject: below --
2009-03-20 10:02 [PATCH 00/25] Cleanup and optimise the page allocator V5 Mel Gorman
2009-03-20 10:02 ` [PATCH 03/25] Do not check NUMA node ID when the caller knows the node is valid Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49ED60E9.4030005@cs.helsinki.fi \
--to=penberg@cs.helsinki.fi \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=ming.m.lin@intel.com \
--cc=npiggin@suse.de \
--cc=peterz@infradead.org \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).