From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC876C3064D for ; Tue, 2 Jul 2024 10:49:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5726F6B009D; Tue, 2 Jul 2024 06:49:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 522006B00A3; Tue, 2 Jul 2024 06:49:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C2BD6B00A5; Tue, 2 Jul 2024 06:49:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 152CE6B009D for ; Tue, 2 Jul 2024 06:49:03 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B7FB9A46D5 for ; Tue, 2 Jul 2024 10:49:02 +0000 (UTC) X-FDA: 82294490124.06.721A5B2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 5DC08180014 for ; Tue, 2 Jul 2024 10:49:00 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bpSGZ8Ud; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719917323; a=rsa-sha256; cv=none; b=irIxbWT08Qm2A7CGEsv6J410HT7fL7Se2JiHl2FH6ptclNKCOQMJliagIa4+coZIKTSwzf Qg2QFIwiuCqS3Dym9V0ZEOQ4InYOpMPDU4q8kTt2k+SlbunzLlEYFXI6pWqMbDvpWSy09c ncUc4o5r4z47Gt7voBFJAQ3w+wdOrTQ= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bpSGZ8Ud; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719917323; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e40lUf574M4qXxXXDozor7zE2aQYYc5FGooszxB9ayw=; b=770Ys5znhiTUz0mpiP/NmHL5sPCbgS964B61kHrB0uZumgm27vOL8+q7GCiZyqKRyN5Uyb Xe2YJvMZ9nrBPFHQmeJqDebPCmKJUi3UoYLRwpvN4KwaNsT4ffUozNjBn9BI684YXwFSpt iTI/4gMcksrqpzxxo1L4/V1j0gqGh7o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719917339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=e40lUf574M4qXxXXDozor7zE2aQYYc5FGooszxB9ayw=; b=bpSGZ8UdKQHcXfKuXQ98LqR0CCSOOSI3q1+30JJp0ILkK2BFA6i7eWtnHcBBo6XkP0Qgv2 Vpw+8De9IJbzAIU8nIlihs18Ka6/EnGodSYG182tzB8dbr54Suq4G8YyAqUK1Adt3T04qO D6tfr3kjhVe+JLg68Rym0HH8Km/j08k= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-70-9cf4abnRPTmvY0NAdRngfQ-1; Tue, 02 Jul 2024 06:48:58 -0400 X-MC-Unique: 9cf4abnRPTmvY0NAdRngfQ-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-42566e8a9efso37159885e9.2 for ; Tue, 02 Jul 2024 03:48:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719917337; x=1720522137; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=e40lUf574M4qXxXXDozor7zE2aQYYc5FGooszxB9ayw=; b=IiSBL+eKOaUYRiItNpC2Edk5racBdblhrplCHL8TF2fKcwgB5twG4knTrBPE/9egsB LaKloGHHC8Bseacu/jZZHggrRRh3A9BO9nMefkNUtc83VqEGpw5d6C8zkfgQm6VY1Mtu lsI/oJCStq+njlUxzuUMHH+FfoyUyE/JljSUZ0PXzl4jTkcOQvJSigqKGiGurnHbzN8b mRJGclTb2JRhuHlTs8uFEKt/khnKngQVjpQV5H1X3vVcIozFs40rGXR7/K+16WiWkwHr HAYvdf2YxVLA+6Cyssr/rRjpY3XNiLfepF9mskZr5MkzFX/6GnbAEr8dfXCcegAsQZen zNlQ== X-Forwarded-Encrypted: i=1; AJvYcCWFftziUoCiMxEHnrA+a09hlLNyVKbeFAiLO8dSZ+auoewFdxXmiVorFJGmdCq1ivh2CCfueip5dSH9PYOB4XNNfU0= X-Gm-Message-State: AOJu0YzXuEAIn+DePkpMeNZB+F9YdAZAsH3v5HFFQiSwgafCsNw7x1Wg El3EDsqniZjwbhLtu+ZaP3iMbC6k+Rc6IovlbktJ69mJOcsxWRv2jrd0ITlB5fND07R7n8XqBqv 0bseLCYCiDPmIHhla/7j6/p4tty8CIDXJFRdGKXiIAtj40yt1 X-Received: by 2002:a05:600c:26c8:b0:424:a587:4392 with SMTP id 5b1f17b1804b1-4257a00bf07mr69405825e9.18.1719917337009; Tue, 02 Jul 2024 03:48:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IElVpxJjsjgmIY/02xE5nrq6WSECRBJ5vGvYOI17Ei9pKZ1oIb3sEwCyqTAcHum0fUrwRrmDg== X-Received: by 2002:a05:600c:26c8:b0:424:a587:4392 with SMTP id 5b1f17b1804b1-4257a00bf07mr69405445e9.18.1719917336542; Tue, 02 Jul 2024 03:48:56 -0700 (PDT) Received: from ?IPV6:2003:cb:c739:2400:78ac:64bb:a39e:2578? (p200300cbc739240078ac64bba39e2578.dip0.t-ipconnect.de. [2003:cb:c739:2400:78ac:64bb:a39e:2578]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4256b064f16sm193449815e9.27.2024.07.02.03.48.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Jul 2024 03:48:56 -0700 (PDT) Message-ID: <49ab22b4-ed27-4a72-9978-aaa9328870a3@redhat.com> Date: Tue, 2 Jul 2024 12:48:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 09/13] gup: Don't allow FOLL_LONGTERM pinning of FS DAX pages To: Alistair Popple Cc: dan.j.williams@intel.com, vishal.l.verma@intel.com, dave.jiang@intel.com, logang@deltatee.com, bhelgaas@google.com, jack@suse.cz, jgg@ziepe.ca, catalin.marinas@arm.com, will@kernel.org, mpe@ellerman.id.au, npiggin@gmail.com, dave.hansen@linux.intel.com, ira.weiny@intel.com, willy@infradead.org, djwong@kernel.org, tytso@mit.edu, linmiaohe@huawei.com, peterx@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, david@fromorbit.com References: <74a9fc9e018e54d7afbeae166479e2358e0a1225.1719386613.git-series.apopple@nvidia.com> <87le2klleb.fsf@nvdebian.thelocal> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <87le2klleb.fsf@nvdebian.thelocal> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 5DC08180014 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: t65i579x9g6g9caucwfnw5kp8adsdg6t X-HE-Tag: 1719917340-774868 X-HE-Meta: U2FsdGVkX1/1CyVBFRYb95ZnP42jtdWSUZyzCgsLQFxYH9IXqG9BnRncZ6FphbhZazeSib3Ug8dQwvl3mlIAh89EI2XcrMxQssLbgMOF2gp4NG5wXeb1JpAWECVxWPvFIPv2y26gsdQjb6MPgdQf/yhtrQVGof28MXDBmwaLMkjrY/K7JAWVjY3owBFRXoqDXZfzxnUHbc/oMLJW8G0oL7o220lZDAOWSHEO/HXJFtNJVKI8biMqeZTTk+IWP6ob4EoR11hr7a1zu833UV/USs9bz6dFxd4E0cjH31jgiglhiZMXefBK4l4rL5fJm5wi0vEDkD5S8I8abALES8fX/8YrlOr5DO84DOn7Jfa9lpbPAAsve17BXvLqXvG30jYUUWM5+BI/S6IkA8dX/SqmakPck1qNh+sN1DGmOrmI3yRtD1B1pHbzKHPMqpneYLTbiYVoPvPjQGZrs7BOR29Nqt98xQR+peSvLiJDJbrBj+m3nmHoewauibgf+9aybi52OJaSiDEPnkQyr/3pNhrtRPsP0RXz7omQIOZX01R5f/CRmr+JU3+GOpDcjM8Vermu1tmj6xr6LDBeHrsYfLvGlfJxPHK/a00w/XS0CgDMLR6TZHwF7BFrPSq92sy7urs/NagoEnfZRgRZHrRr590Lu1xbZBuo8goNZxAvwbf8n3sbY82IoN1aO0D2KjUmZaUl1UiM8CIf5QMuSLFKFdWar33ceyKo8USP2z/b5J3knkjLPPxMihddP3tzJw9DwFJuarK21DCnr2p2p4+HlAE1J21WqtNNUVyUG2T6cxpWiPkcJLGXVr7SfDi59ZoXRXaAlqC89W313Aw8ROSROWtuNOQN2WCHhdusXA6M+I0byikUgsIyC7BmvlgFNO6Ggjqgyt5wpKSaZWa/IIr84HbzW0jcSwG+8t/tcToGP9qYErTl92OsITo0MxRSNO1bjTonXrDDbE/NoYh1rawPgyu KiwRR8p9 AO0vbo0elxzsovaGw8cBEHaaW3nd6SYKj9WfuL+XX4smO3z1XDH7SDXDRBWhaLzz8lFg+JD38fevbjwlkiSa1y4OYI6KbqIgUcxs7E8n+IzpgeaAPOJFUj0PY6o/O/oPs7SB3ytwsJ7/8uO4rHh5TLjlciKvbqtbUbshImVq81rjSSXx9N3n4u5FZZwC0IK01nJNlFPVJIf++LXVXINIlmsAz4iPibj8IcVanqu0qK0RSfkn5LoiyOUDFM0FApe78YYHnV9AQ/7gSw3NB9M3H+B1HzDDB7OYmS+a4HaDqTxSRyant/reGIfu8fMASnDmOMF1MLs1LlUPI4o+abORmtiajlLsxyK2/zzcm3zo3GpglM/D2Aad7SnmWsVGcsY1xMAXNIB+wyvSLhR+GW1hNK4ZgiYP2L1B0plOPP4HOfFoZe9w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.07.24 01:47, Alistair Popple wrote: > > David Hildenbrand writes: > >> On 27.06.24 02:54, Alistair Popple wrote: >>> Longterm pinning of FS DAX pages should already be disallowed by >>> various pXX_devmap checks. However a future change will cause these >>> checks to be invalid for FS DAX pages so make >>> folio_is_longterm_pinnable() return false for FS DAX pages. >>> Signed-off-by: Alistair Popple >>> --- >>> include/linux/memremap.h | 11 +++++++++++ >>> include/linux/mm.h | 4 ++++ >>> 2 files changed, 15 insertions(+) >>> diff --git a/include/linux/memremap.h b/include/linux/memremap.h >>> index 6505713..19a448e 100644 >>> --- a/include/linux/memremap.h >>> +++ b/include/linux/memremap.h >>> @@ -193,6 +193,17 @@ static inline bool folio_is_device_coherent(const struct folio *folio) >>> return is_device_coherent_page(&folio->page); >>> } >>> +static inline bool is_device_dax_page(const struct page *page) >>> +{ >>> + return is_zone_device_page(page) && >>> + page_dev_pagemap(page)->type == MEMORY_DEVICE_FS_DAX; >>> +} >>> + >>> +static inline bool folio_is_device_dax(const struct folio *folio) >>> +{ >>> + return is_device_dax_page(&folio->page); >>> +} >>> + >>> #ifdef CONFIG_ZONE_DEVICE >>> void zone_device_page_init(struct page *page); >>> void *memremap_pages(struct dev_pagemap *pgmap, int nid); >>> diff --git a/include/linux/mm.h b/include/linux/mm.h >>> index b84368b..4d1cdea 100644 >>> --- a/include/linux/mm.h >>> +++ b/include/linux/mm.h >>> @@ -2032,6 +2032,10 @@ static inline bool folio_is_longterm_pinnable(struct folio *folio) >>> if (folio_is_device_coherent(folio)) >>> return false; >>> + /* DAX must also always allow eviction. */ >>> + if (folio_is_device_dax(folio)) >>> + return false; >>> + >>> /* Otherwise, non-movable zone folios can be pinned. */ >>> return !folio_is_zone_movable(folio); >>> >> >> Why is the check in check_vma_flags() insufficient? GUP-fast maybe? > > Right. This came up when I was changing the code for GUP-fast, but also > they shouldn't be longterm pinnable and adding the case to > folio_is_longterm_pinnable() is an excellent way of documenting that. Makes sense, might be worth adding that (GUP-fast and check_vma_flags() covering GUP-slow) to the patch description. -- Cheers, David / dhildenb