From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82CEFC4332F for ; Mon, 28 Nov 2022 08:43:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 165E56B0074; Mon, 28 Nov 2022 03:43:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 117136B0075; Mon, 28 Nov 2022 03:43:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF8FC6B0078; Mon, 28 Nov 2022 03:43:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E01A36B0074 for ; Mon, 28 Nov 2022 03:43:11 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B47E21607F8 for ; Mon, 28 Nov 2022 08:43:11 +0000 (UTC) X-FDA: 80182211382.17.26FC756 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 25F5FC000B for ; Mon, 28 Nov 2022 08:43:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669624989; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u3Z+f4VZMDJxUPd/+Sf3TcgkW0sRdaW9hPXh2uZaLNU=; b=aG6RpR+pzwJW9vwZIDlDLO9WRXTRWxBqmvLLcUlMmgOj03A8CgEufcwpPRzIprJ1tUgNHd Cob26gojGl+uAT3/aw+S8el14gmr11ieN7ayEVq+I87JxVrrD0ftclLkITSx6j1k8pLITM RS1zq6sk/2jE5E5en/cXfAA3kL0jGCU= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-648-2suzgQO8MSC983MjXr8tjA-1; Mon, 28 Nov 2022 03:43:08 -0500 X-MC-Unique: 2suzgQO8MSC983MjXr8tjA-1 Received: by mail-wr1-f70.google.com with SMTP id p2-20020adfaa02000000b00241d7fb17d7so1620573wrd.5 for ; Mon, 28 Nov 2022 00:43:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=u3Z+f4VZMDJxUPd/+Sf3TcgkW0sRdaW9hPXh2uZaLNU=; b=FIBtp0W6342LweQ+G/8R31qbxxxt2mV8uKD+R9WB/80cRbnfNEUIPGALz2XgavuRKH SqvUFidwBEKQofzGiDEpYra77NjlLU1Uz0p61Xm4Rb0SEr1ojCw4OGJEKeU5xBHuAe9x bjMHR5C3O9O++bZKVFRVoyVFIml4OMzKyYI9aKMn2KXp6ponuZoFY+LbgAW4RGc53O1M D61pOLrN+BCntaHARy/iXCpS9Iom+cyzjLA1l2RSb1s42Nnrj5y9T5A9ja5pgQhUQ2E1 LyRcXfRLFQgHoJAUbomU0XBBMPJvsMS+nCS72MB8ucNwAzG/EUOSuNYvBZXy+WHcxaAv Q6Iw== X-Gm-Message-State: ANoB5pkMAr97HnmkPUL1BoEy92C88TXFFE2UV0U7oD219fyG+xbSje9X YYOca2CbeXheOspYD1/cyPkeFboy7MNRj69DULSlRnzopjksKugJ/0vPw1R3IAcM3ZFtmFQTAz6 5yD/R/gytNJI= X-Received: by 2002:adf:f650:0:b0:241:f0c6:11bb with SMTP id x16-20020adff650000000b00241f0c611bbmr14591285wrp.389.1669624987252; Mon, 28 Nov 2022 00:43:07 -0800 (PST) X-Google-Smtp-Source: AA0mqf7tYyRPHGtVQ1+TZNLDaZiRIq2vii8ri7zjcAuldMIqwe9YPM1WwXwe8PDxctzR9eiFdQ8vew== X-Received: by 2002:adf:f650:0:b0:241:f0c6:11bb with SMTP id x16-20020adff650000000b00241f0c611bbmr14591257wrp.389.1669624986924; Mon, 28 Nov 2022 00:43:06 -0800 (PST) Received: from ?IPV6:2003:cb:c702:9000:3d6:e434:f8b4:80cf? (p200300cbc702900003d6e434f8b480cf.dip0.t-ipconnect.de. [2003:cb:c702:9000:3d6:e434:f8b4:80cf]) by smtp.gmail.com with ESMTPSA id y8-20020adffa48000000b00241f029e672sm10037075wrr.107.2022.11.28.00.43.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Nov 2022 00:43:06 -0800 (PST) Message-ID: <49ab9f26-9e23-25ab-71b4-e666c70ff77e@redhat.com> Date: Mon, 28 Nov 2022 09:43:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v7 10/20] x86/virt/tdx: Use all system memory when initializing TDX module as TDX memory To: "Huang, Kai" , "Williams, Dan J" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Cc: "Hansen, Dave" , "Luck, Tony" , "bagasdotme@gmail.com" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "kirill.shutemov@linux.intel.com" , "Christopherson,, Sean" , "Chatre, Reinette" , "pbonzini@redhat.com" , "linux-mm@kvack.org" , "Yamahata, Isaku" , "Shahar, Sagi" , "imammedo@redhat.com" , "Gao, Chao" , "Brown, Len" , "peterz@infradead.org" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" References: <9b545148275b14a8c7edef1157f8ec44dc8116ee.1668988357.git.kai.huang@intel.com> <637ecded7b0f9_160eb329418@dwillia2-xfh.jf.intel.com.notmuch> <8e8f72ad5d7a3d09be32bee54e4ebb9c280610a2.camel@intel.com> <361875cb-e4b3-a46f-b275-6d87a98ce966@redhat.com> <397ebe70bf9cede731f2f8bbd05e0df518fd3a22.camel@intel.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <397ebe70bf9cede731f2f8bbd05e0df518fd3a22.camel@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669624991; a=rsa-sha256; cv=none; b=JwMvqlLsWHCrqy2rfmlI2KQ23sj6i9M9HkPW8ruKKdgqNIRAq1nKDdKUkMbPQqstrdgU+g iGfgn/1ixxwY9dpGcnIaj2G7z67pkduz49c93LiHi1idgoZDWgtFte6dUemrO/NIZHPWHc Jfqci7odb6mrULUibaLaRQN3PZEQCxw= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aG6RpR+p; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669624991; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u3Z+f4VZMDJxUPd/+Sf3TcgkW0sRdaW9hPXh2uZaLNU=; b=7AH1WTA8gOPULljAcA4Ss5U5KJdI6rU+TjBvXEjhI9NHHeD+yrUPWcYbEYJR2mwo5/OFfU VCyrItRV1tGWReTVdLKJPGZoMXYFUoFTPzuQOLZVnTkj5K7jie0mQPYoysDzWDJ66moNNq FLSiaoFd81507PObDCxzXy9XhTqG4vU= X-Stat-Signature: 5s4ab59ixdwp3b8rjtwchokocueyumhi X-Rspamd-Queue-Id: 25F5FC000B X-Rspam-User: Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aG6RpR+p; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam10 X-HE-Tag: 1669624990-903320 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 28.11.22 09:38, Huang, Kai wrote: > On Fri, 2022-11-25 at 10:28 +0100, David Hildenbrand wrote: >> On 24.11.22 10:06, Huang, Kai wrote: >>> On Wed, 2022-11-23 at 17:50 -0800, Dan Williams wrote: >>>>> >>>>> @@ -968,6 +969,15 @@ int arch_add_memory(int nid, u64 start, u64 size, >>>>>    unsigned long start_pfn = start >> PAGE_SHIFT; >>>>>    unsigned long nr_pages = size >> PAGE_SHIFT; >>>>> >>>>> + /* >>>>> + * For now if TDX is enabled, all pages in the page allocator >>>>> + * must be TDX memory, which is a fixed set of memory regions >>>>> + * that are passed to the TDX module.  Reject the new region >>>>> + * if it is not TDX memory to guarantee above is true. >>>>> + */ >>>>> + if (!tdx_cc_memory_compatible(start_pfn, start_pfn + nr_pages)) >>>>> + return -EINVAL; >>>> >>>> arch_add_memory() does not add memory to the page allocator.  For >>>> example, memremap_pages() uses arch_add_memory() and explicitly does not >>>> release the memory to the page allocator. >>> >>> Indeed. Sorry I missed this. >>> >>>> This check belongs in >>>> add_memory_resource() to prevent new memory that violates TDX from being >>>> onlined. >>> >>> This would require adding another 'arch_cc_memory_compatible()' to the common >>> add_memory_resource() (I actually long time ago had such patch to work with the >>> memremap_pages() you mentioned above). >>> >>> How about adding a memory_notifier to the TDX code, and reject online of TDX >>> incompatible memory (something like below)? The benefit is this is TDX code >>> self contained and won't pollute the common mm code: >>> >>> +static int tdx_memory_notifier(struct notifier_block *nb, >>> + unsigned long action, void *v) >>> +{ >>> + struct memory_notify *mn = v; >>> + >>> + if (action != MEM_GOING_ONLINE) >>> + return NOTIFY_OK; >>> + >>> + /* >>> + * Not all memory is compatible with TDX. Reject >>> + * online of any incompatible memory. >>> + */ >>> + return tdx_cc_memory_compatible(mn->start_pfn, >>> + mn->start_pfn + mn->nr_pages) ? NOTIFY_OK : NOTIFY_BAD; >>> +} >>> + >>> +static struct notifier_block tdx_memory_nb = { >>> + .notifier_call = tdx_memory_notifier, >>> +}; >> >> With mhp_memmap_on_memory() some memory might already be touched during >> add_memory() (because part of the hotplug memory is used for holding the >> memmap), not when actually onlining memory. So in that case, this would >> be too late. > > Hi David, > > Thanks for the review! > > Right. The memmap pages are added to the zone before online_pages(), but IIUC > those memmap pages will never be free pages thus won't be allocated by the page > allocator, correct? Therefore in practice there won't be problem even they are > not TDX compatible memory. But that memory will be read/written. Isn't that an issue, for example, if memory doesn't get accepted etc? -- Thanks, David / dhildenb