From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with SMTP id 8177E6B0148 for ; Wed, 13 May 2009 20:14:51 -0400 (EDT) Received: by yx-out-1718.google.com with SMTP id 36so489540yxh.26 for ; Wed, 13 May 2009 17:15:04 -0700 (PDT) Message-ID: <4A0B6283.9040106@codemonkey.ws> Date: Wed, 13 May 2009 19:14:59 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [PATCH 5/5] add ksm kernel shared memory driver. References: <1240191366-10029-1-git-send-email-ieidus@redhat.com> <1240191366-10029-2-git-send-email-ieidus@redhat.com> <1240191366-10029-3-git-send-email-ieidus@redhat.com> <1240191366-10029-4-git-send-email-ieidus@redhat.com> <1240191366-10029-5-git-send-email-ieidus@redhat.com> <1240191366-10029-6-git-send-email-ieidus@redhat.com> <20090513161739.d801ab67.akpm@linux-foundation.org> <20090513232520.GN12533@x200.localdomain> In-Reply-To: <20090513232520.GN12533@x200.localdomain> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Chris Wright Cc: Andrew Morton , Izik Eidus , linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org, avi@redhat.com, aarcange@redhat.com, mtosatti@redhat.com, hugh@veritas.com List-ID: Chris Wright wrote: > * Andrew Morton (akpm@linux-foundation.org) wrote: > >> Breaks ppc64 allmodcofnig because that architecture doesn't export its >> copy_user_page() to modules. >> > > Things like this and updating to use madvise() I think all point towards > s/tristate/bool/. I don't think CONFIG_KSM=M has huge benefit. > I agree. Regards, Anthony Liguori -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org