From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail202.messagelabs.com (mail202.messagelabs.com [216.82.254.227]) by kanga.kvack.org (Postfix) with SMTP id 60B366B004F for ; Fri, 29 May 2009 12:34:05 -0400 (EDT) Message-ID: <4A200E98.20306@redhat.com> Date: Fri, 29 May 2009 12:34:32 -0400 From: Rik van Riel MIME-Version: 1.0 Subject: Re: [PATCH] [1/16] HWPOISON: Add page flag for poisoned pages References: <200905271012.668777061@firstfloor.org> <20090527201226.CCCBB1D028F@basil.firstfloor.org> <20090527221510.5e418e97@lxorguk.ukuu.org.uk> <20090528075416.GY1065@one.firstfloor.org> <4A2008F0.1070304@redhat.com> <20090529163757.GX1065@one.firstfloor.org> In-Reply-To: <20090529163757.GX1065@one.firstfloor.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Andi Kleen Cc: Alan Cox , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, fengguang.wu@intel.com List-ID: Andi Kleen wrote: > On Fri, May 29, 2009 at 12:10:24PM -0400, Rik van Riel wrote: >> Andi Kleen wrote: >>> On Wed, May 27, 2009 at 10:15:10PM +0100, Alan Cox wrote: >>>> On Wed, 27 May 2009 22:12:26 +0200 (CEST) >>>> Andi Kleen wrote: >>>> >>>>> Hardware poisoned pages need special handling in the VM and shouldn't be >>>>> touched again. This requires a new page flag. Define it here. >>>> Why can't you use PG_reserved ? That already indicates the page may not >>>> even be present (which is effectively your situation at that point). >>> Right now a page must be present with PG_reserved, otherwise /dev/mem, >>> /proc/kcore >>> lots of other things will explode. >> Could we use a combination of, say PG_reserved and >> PG_writeback to keep /dev/mem and /proc/kcore from >> exploding ? > > They should just check for poisoned pages. #define PagePoisoned(page) (PageReserved(page) && PageWriteback(page)) -- All rights reversed. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org