From: Tejun Heo <tj@kernel.org>
To: Christoph Lameter <cl@linux-foundation.org>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org, mingo@elte.hu,
rusty@rustcorp.com.au, davem@davemloft.net
Subject: Re: [this_cpu_xx V2 10/19] this_cpu: X86 optimized this_cpu operations
Date: Fri, 19 Jun 2009 01:15:55 +0900 [thread overview]
Message-ID: <4A3A683B.7090304@kernel.org> (raw)
In-Reply-To: <4A3A65F7.6070404@kernel.org>
Tejun Heo wrote:
> Functionally, there's no practical difference but it's just weird to
> use scalar as input/output parameter. All the atomic and bitops
> operations are taking pointers. In fact, there are only very few
> which take lvalue input and modify it, so I think it would be much
> better to take pointers like normal C functions and macros for the
> sake of consistency.
One notable exception tho is the get/put_user() macros. In that these
percpu ops behave differently depending on input parameter size might
put them closer to get/put_user() than other atomic / bitops
operations. Eh... I'm not so sure anymore. It's purely interface
decision. Ingo, Rusty, what do you guys think?
Thanks.
--
tejun
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-06-18 16:13 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-17 20:33 [this_cpu_xx V2 00/19] Introduce this_cpu_xx operations cl
2009-06-17 20:33 ` [this_cpu_xx V2 01/19] Fix handling of pagesets for downed cpus cl
2009-06-17 20:33 ` [this_cpu_xx V2 02/19] Introduce this_cpu_ptr() and generic this_cpu_* operations cl
2009-06-18 1:50 ` Tejun Heo
2009-06-18 2:29 ` Tejun Heo
2009-06-18 13:54 ` Christoph Lameter
2009-06-18 14:49 ` Tejun Heo
2009-06-17 20:33 ` [this_cpu_xx V2 03/19] Use this_cpu operations for SNMP statistics cl
2009-06-18 1:55 ` Tejun Heo
2009-06-17 20:33 ` [this_cpu_xx V2 04/19] Use this_cpu operations for NFS statistics cl
2009-06-18 2:03 ` Tejun Heo
2009-06-17 20:33 ` [this_cpu_xx V2 05/19] use this_cpu ops for network statistics cl
2009-06-17 20:33 ` [this_cpu_xx V2 06/19] this_cpu_ptr: Straight transformations cl
2009-06-17 20:33 ` [this_cpu_xx V2 07/19] this_cpu_ptr: Elimninate get/put_cpu cl
2009-06-17 20:33 ` [this_cpu_xx V2 08/19] this_cpu_ptr: xfs_icsb_modify_counters does not need "cpu" variable cl
2009-06-17 20:33 ` [this_cpu_xx V2 09/19] Use this_cpu_ptr in crypto subsystem cl
2009-06-17 20:33 ` [this_cpu_xx V2 10/19] this_cpu: X86 optimized this_cpu operations cl
2009-06-18 3:00 ` Tejun Heo
2009-06-18 14:07 ` Christoph Lameter
2009-06-18 14:48 ` Tejun Heo
2009-06-18 15:39 ` Christoph Lameter
2009-06-18 16:06 ` Tejun Heo
2009-06-18 16:15 ` Tejun Heo [this message]
2009-06-18 17:05 ` Christoph Lameter
2009-06-19 5:41 ` Rusty Russell
2009-06-23 18:00 ` Christoph Lameter
2009-06-17 20:33 ` [this_cpu_xx V2 11/19] Use this_cpu ops for VM statistics cl
2009-06-18 3:05 ` Tejun Heo
2009-06-17 20:33 ` [this_cpu_xx V2 12/19] RCU: Use this_cpu operations cl
2009-06-17 20:33 ` [this_cpu_xx V2 13/19] Use this_cpu operations in slub cl
2009-06-18 6:20 ` Pekka Enberg
2009-06-18 6:25 ` Pekka Enberg
2009-06-18 13:59 ` Christoph Lameter
2009-06-25 7:12 ` Pekka Enberg
2009-06-18 6:49 ` Tejun Heo
2009-06-18 7:35 ` Pekka Enberg
2009-06-18 13:59 ` Christoph Lameter
2009-06-25 7:11 ` Pekka Enberg
2009-06-17 20:33 ` [this_cpu_xx V2 14/19] this_cpu: Remove slub kmem_cache fields cl
2009-06-17 20:33 ` [this_cpu_xx V2 15/19] Make slub statistics use this_cpu_inc cl
2009-06-17 20:33 ` [this_cpu_xx V2 16/19] this_cpu: slub aggressive use of this_cpu operations in the hotpaths cl
2009-06-18 6:33 ` Pekka Enberg
2009-06-18 11:59 ` Mathieu Desnoyers
2009-06-18 14:00 ` Christoph Lameter
2009-06-17 20:33 ` [this_cpu_xx V2 17/19] Move early initialization of pagesets out of zone_wait_table_init() cl
2009-06-18 3:13 ` Tejun Heo
2009-06-17 20:33 ` [this_cpu_xx V2 18/19] this_cpu_ops: page allocator conversion cl
2009-06-17 20:33 ` [this_cpu_xx V2 19/19] this_cpu ops: Remove pageset_notifier cl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A3A683B.7090304@kernel.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).