From: Rik van Riel <riel@redhat.com>
To: Christoph Lameter <cl@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Wu Fengguang <fengguang.wu@intel.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Minchan Kim <minchan.kim@gmail.com>,
Johannes Weiner <hannes@cmpxchg.org>,
David Howells <dhowells@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
"tytso@mit.edu" <tytso@mit.edu>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"elladan@eskimo.com" <elladan@eskimo.com>,
"npiggin@suse.de" <npiggin@suse.de>,
"Barnes, Jesse" <jesse.barnes@intel.com>
Subject: Re: [PATCH] mm: count only reclaimable lru pages
Date: Thu, 16 Jul 2009 10:42:56 -0400 [thread overview]
Message-ID: <4A5F3C70.7010001@redhat.com> (raw)
In-Reply-To: <alpine.DEB.1.10.0907161037590.7930@gentwo.org>
Christoph Lameter wrote:
> On Thu, 16 Jul 2009, Peter Zijlstra wrote:
>
>>> What would you suggest? In fact I'm not totally comfortable with it.
>>> Maybe it would be safer to simply stick with the old _lru_pages
>>> naming?
>> Nah, I like the reclaimable name, these pages are at least potentially
>> reclaimable.
>>
>> lru_pages() is definately not correct anymore since you exclude the
>> unevictable and possibly the anon pages.
>
> Well lets at least add a comment at the beginning of the functions
> explaining that these are potentially reclaimable and list some of the
> types of pages that may not be reclaimable.
The pages that are not reclaimable will be on the
unevictable LRU list, not on the lists we count.
The only case of pages not being evictable is the
anon pages, once swap fills up.
--
All rights reversed.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-07-16 14:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-16 13:34 [PATCH] mm: count only reclaimable lru pages Wu Fengguang
2009-07-16 13:40 ` Peter Zijlstra
2009-07-16 13:49 ` Rik van Riel
2009-07-16 14:00 ` Christoph Lameter
2009-07-16 14:25 ` Wu Fengguang
2009-07-16 14:28 ` Peter Zijlstra
2009-07-16 14:39 ` Christoph Lameter
2009-07-16 14:42 ` Rik van Riel [this message]
2009-07-16 15:09 ` [PATCH] mm: count only reclaimable lru pages v2 Wu Fengguang
2009-07-16 15:59 ` Johannes Weiner
2009-07-16 16:21 ` Christoph Lameter
2009-07-16 23:53 ` KOSAKI Motohiro
2009-07-16 14:17 ` [PATCH] mm: count only reclaimable lru pages Minchan Kim
2009-07-16 16:15 ` David Howells
2009-07-16 16:24 ` Rik van Riel
2009-07-16 17:11 ` David Howells
2009-07-16 18:51 ` Li, Ming Chun
2009-07-17 4:57 ` KOSAKI Motohiro
2009-07-17 6:32 ` Li, Ming Chun
2009-07-16 16:21 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A5F3C70.7010001@redhat.com \
--to=riel@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=elladan@eskimo.com \
--cc=fengguang.wu@intel.com \
--cc=hannes@cmpxchg.org \
--cc=jesse.barnes@intel.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=npiggin@suse.de \
--cc=peterz@infradead.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).