From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail190.messagelabs.com (mail190.messagelabs.com [216.82.249.51]) by kanga.kvack.org (Postfix) with SMTP id 478A36B0055 for ; Mon, 20 Jul 2009 11:05:39 -0400 (EDT) Message-ID: <4A6487BC.3000605@redhat.com> Date: Mon, 20 Jul 2009 11:05:32 -0400 From: Rik van Riel MIME-Version: 1.0 Subject: Re: [PATCH 02/10] ksm: first tidy up madvise_vma() References: <1247851850-4298-1-git-send-email-ieidus@redhat.com> <1247851850-4298-2-git-send-email-ieidus@redhat.com> <1247851850-4298-3-git-send-email-ieidus@redhat.com> In-Reply-To: <1247851850-4298-3-git-send-email-ieidus@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Izik Eidus Cc: akpm@linux-foundation.org, hugh.dickins@tiscali.co.uk, aarcange@redhat.com, chrisw@redhat.com, avi@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, nickpiggin@yahoo.com.au List-ID: Izik Eidus wrote: > From: Hugh Dickins > > madvise.c has several levels of switch statements, what to do in which? > Move MADV_DOFORK code down from madvise_vma() to madvise_behavior(), so > madvise_vma() can be a simple router, to madvise_behavior() by default. > > vma->vm_flags is an unsigned long so use the same type for new_flags. > Add missing comment lines to describe MADV_DONTFORK and MADV_DOFORK. > > Signed-off-by: Hugh Dickins > Signed-off-by: Chris Wright > Signed-off-by: Izik Eidus Acked-by: Rik van Riel -- All rights reversed. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org