* Replacing 0x% with %# ?
@ 2009-07-20 22:53 Li, Ming Chun
2009-07-21 6:50 ` KOSAKI Motohiro
0 siblings, 1 reply; 5+ messages in thread
From: Li, Ming Chun @ 2009-07-20 22:53 UTC (permalink / raw)
To: linux-mm
Hi MM list:
I am newbie and wish to contribute tiny bit. Before I submit a
trivial patch, I would ask if it is worth replacing '0x%' with '%#' in printk in mm/*.c?
If it is going to be noise for you guys, I would drop it and keep silent
:).
Vincent Li
Biomedical Research Center
University of British Columbia
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Replacing 0x% with %# ?
2009-07-20 22:53 Replacing 0x% with %# ? Li, Ming Chun
@ 2009-07-21 6:50 ` KOSAKI Motohiro
2009-07-22 23:24 ` H. Peter Anvin
0 siblings, 1 reply; 5+ messages in thread
From: KOSAKI Motohiro @ 2009-07-21 6:50 UTC (permalink / raw)
To: Li, Ming Chun; +Cc: kosaki.motohiro, linux-mm
>
> Hi MM list:
>
> I am newbie and wish to contribute tiny bit. Before I submit a
> trivial patch, I would ask if it is worth replacing '0x%' with '%#' in printk in mm/*.c?
> If it is going to be noise for you guys, I would drop it and keep silent
> :).
Never mind. we already post many trivial cleanup patches.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Replacing 0x% with %# ?
2009-07-21 6:50 ` KOSAKI Motohiro
@ 2009-07-22 23:24 ` H. Peter Anvin
2009-07-23 17:41 ` KOSAKI Motohiro
0 siblings, 1 reply; 5+ messages in thread
From: H. Peter Anvin @ 2009-07-22 23:24 UTC (permalink / raw)
To: KOSAKI Motohiro; +Cc: Li, Ming Chun, linux-mm
KOSAKI Motohiro wrote:
>> Hi MM list:
>>
>> I am newbie and wish to contribute tiny bit. Before I submit a
>> trivial patch, I would ask if it is worth replacing '0x%' with '%#' in printk in mm/*.c?
>> If it is going to be noise for you guys, I would drop it and keep silent
>> :).
>
> Never mind. we already post many trivial cleanup patches.
>
The other thing is that we reallly should make %p include the 0x prefix,
as it does in userspace.
-hpa
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Replacing 0x% with %# ?
2009-07-22 23:24 ` H. Peter Anvin
@ 2009-07-23 17:41 ` KOSAKI Motohiro
2009-07-23 18:01 ` H. Peter Anvin
0 siblings, 1 reply; 5+ messages in thread
From: KOSAKI Motohiro @ 2009-07-23 17:41 UTC (permalink / raw)
To: H. Peter Anvin; +Cc: Li, Ming Chun, linux-mm
>>> Hi MM list:
>>>
>>> I am newbie and wish to contribute tiny bit. Before I submit a trivial
>>> patch, I would ask if it is worth replacing '0x%' with '%#' in printk in
>>> mm/*.c? If it is going to be noise for you guys, I would drop it and keep
>>> silent :).
>>
>> Never mind. we already post many trivial cleanup patches.
>>
>
> The other thing is that we reallly should make %p include the 0x prefix, as
> it does in userspace.
I think you mean %x, not %p. if so, I agree you. this difference
doesn't make any sense.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Replacing 0x% with %# ?
2009-07-23 17:41 ` KOSAKI Motohiro
@ 2009-07-23 18:01 ` H. Peter Anvin
0 siblings, 0 replies; 5+ messages in thread
From: H. Peter Anvin @ 2009-07-23 18:01 UTC (permalink / raw)
To: KOSAKI Motohiro; +Cc: Li, Ming Chun, linux-mm
KOSAKI Motohiro wrote:
>>>> Hi MM list:
>>>>
>>>> I am newbie and wish to contribute tiny bit. Before I submit a trivial
>>>> patch, I would ask if it is worth replacing '0x%' with '%#' in printk in
>>>> mm/*.c? If it is going to be noise for you guys, I would drop it and keep
>>>> silent :).
>>> Never mind. we already post many trivial cleanup patches.
>>>
>> The other thing is that we reallly should make %p include the 0x prefix, as
>> it does in userspace.
>
> I think you mean %x, not %p. if so, I agree you. this difference
> doesn't make any sense.
No, I mean %p. %x should definitely not issue the 0x prefix without a #
modifier.
-hpa
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-07-23 18:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-20 22:53 Replacing 0x% with %# ? Li, Ming Chun
2009-07-21 6:50 ` KOSAKI Motohiro
2009-07-22 23:24 ` H. Peter Anvin
2009-07-23 17:41 ` KOSAKI Motohiro
2009-07-23 18:01 ` H. Peter Anvin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).