From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail190.messagelabs.com (mail190.messagelabs.com [216.82.249.51]) by kanga.kvack.org (Postfix) with SMTP id D3BCC6B005A for ; Thu, 6 Aug 2009 09:13:22 -0400 (EDT) Message-ID: <4A7AD6EB.9090208@redhat.com> Date: Thu, 06 Aug 2009 09:13:15 -0400 From: Rik van Riel MIME-Version: 1.0 Subject: Re: [RFC] respect the referenced bit of KVM guest pages? References: <20090805024058.GA8886@localhost> <20090805155805.GC23385@random.random> <20090806100824.GO23385@random.random> <4A7AAE07.1010202@redhat.com> <20090806102057.GQ23385@random.random> <20090806105932.GA1569@localhost> <4A7AC201.4010202@redhat.com> In-Reply-To: <4A7AC201.4010202@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Avi Kivity Cc: Wu Fengguang , Andrea Arcangeli , "Dike, Jeffrey G" , "Yu, Wilfred" , "Kleen, Andi" , Hugh Dickins , Andrew Morton , Christoph Lameter , KOSAKI Motohiro , Mel Gorman , LKML , linux-mm List-ID: Avi Kivity wrote: > On 08/06/2009 01:59 PM, Wu Fengguang wrote: >> As a refinement, the static variable 'recent_all_referenced' could be >> moved to struct zone or made a per-cpu variable. > > Definitely this should be made part of the zone structure, consider the > original report where the problem occurs in a 128MB zone (where we can > expect many pages to have their referenced bit set). The problem did not occur in a 128MB zone, but in a 128MB cgroup. Putting it in the zone means that the cgroup, which may have different behaviour from the rest of the zone, due to excessive memory pressure inside the cgroup, does not get the right statistics. -- All rights reversed. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org