From: Avi Kivity <avi@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Pierre Ossman <drzeus-list@drzeus.cx>,
Minchan Kim <minchan.kim@gmail.com>,
kvm@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, Wu Fengguang <fengguang.wu@intel.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Rik van Riel <riel@redhat.com>,
netdev@vger.kernel.org
Subject: Re: Page allocation failures in guest
Date: Wed, 12 Aug 2009 08:41:21 +0300 [thread overview]
Message-ID: <4A825601.60000@redhat.com> (raw)
In-Reply-To: <200908121501.53167.rusty@rustcorp.com.au>
On 08/12/2009 08:31 AM, Rusty Russell wrote:
> +static void refill_work(struct work_struct *work)
> +{
> + struct virtnet_info *vi;
> + bool still_empty;
> +
> + vi = container_of(work, struct virtnet_info, refill);
> + napi_disable(&vi->napi);
> + try_fill_recv(vi, GFP_KERNEL);
> + still_empty = (vi->num == 0);
> + napi_enable(&vi->napi);
> +
> + /* In theory, this can happen: if we don't get any buffers in
> + * we will*never* try to fill again. Sleeping in keventd if
> + * bad, but that is worse. */
> + if (still_empty) {
> + msleep(100);
> + schedule_work(&vi->refill);
> + }
> +}
> +
>
schedule_delayed_work()?
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-08-12 5:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-13 9:51 Page allocation failures in guest Pierre Ossman
2009-07-13 14:59 ` Minchan Kim
2009-08-11 6:32 ` Pierre Ossman
2009-08-11 6:52 ` Avi Kivity
2009-08-12 3:19 ` Rusty Russell
2009-08-12 5:31 ` Rusty Russell
2009-08-12 5:41 ` Avi Kivity [this message]
2009-08-12 6:56 ` Rusty Russell
2009-08-13 20:25 ` Pierre Ossman
2009-08-26 2:17 ` Rusty Russell
2009-08-26 4:55 ` Pierre Ossman
2009-08-26 12:18 ` Rusty Russell
2009-08-26 19:22 ` David Miller
2009-08-12 6:19 ` Pierre Ossman
2009-08-12 7:43 ` Avi Kivity
2009-08-12 8:22 ` Pierre Ossman
2009-08-12 8:35 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A825601.60000@redhat.com \
--to=avi@redhat.com \
--cc=drzeus-list@drzeus.cx \
--cc=fengguang.wu@intel.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=riel@redhat.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).