From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail190.messagelabs.com (mail190.messagelabs.com [216.82.249.51]) by kanga.kvack.org (Postfix) with ESMTP id D3ECE6B0100 for ; Sat, 19 Sep 2009 03:27:52 -0400 (EDT) Message-ID: <4AB487FD.5060207@cs.helsinki.fi> Date: Sat, 19 Sep 2009 10:27:57 +0300 From: Pekka Enberg MIME-Version: 1.0 Subject: Re: [PATCH 2/4] send callback when swap slot is freed References: <1253227412-24342-1-git-send-email-ngupta@vflare.org> <1253227412-24342-3-git-send-email-ngupta@vflare.org> <1253256805.4959.8.camel@penberg-laptop> <1253260528.4959.13.camel@penberg-laptop> <1253266391.4959.15.camel@penberg-laptop> <4AB3A16B.90009@vflare.org> In-Reply-To: <4AB3A16B.90009@vflare.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: ngupta@vflare.org Cc: Hugh Dickins , Greg KH , Andrew Morton , Ed Tomlinson , linux-kernel , linux-mm , linux-mm-cc , kamezawa.hiroyu@jp.fujitsu.com, nishimura@mxp.nes.nec.co.jp List-ID: Hi Nitin, Nitin Gupta wrote: > It is understood that this swap notify callback is bit of a hack. I think > we will not gain much trying to beautify this hack. However, I agree with > Hugh's suggestion to rename this notify callback related function/variables > to make it explicit that its completely ramzswap related. I will send a > path that affects these renames as reply to patch 0/4. I don't quite agree and do think that my approach is a better long-term solution. That said, it's Hugh's call, not mine. Hugh? Pekka -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org