From: Nigel Cunningham <ncunningham@crca.org.au>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: No more bits in vm_area_struct's vm_flags.
Date: Mon, 28 Sep 2009 15:22:08 +1000 [thread overview]
Message-ID: <4AC04800.70708@crca.org.au> (raw)
In-Reply-To: <20090928135315.083aca18.kamezawa.hiroyu@jp.fujitsu.com>
Hi.
KAMEZAWA Hiroyuki wrote:
> Seems good to me.
>
> Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> But
>> + if (vma->vm_hints)
>> + return 0;
>> return 1;
>
> Maybe adding a comment (or more detailed patch description) is necessary.
Thinking about this some more, I think we should also be looking at whether the new hints are non zero. Perhaps I should just add the new value to the
function parameters and be done with it.
Nigel
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-09-28 16:26 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4AB9A0D6.1090004@crca.org.au>
2009-09-23 20:23 ` No more bits in vm_area_struct's vm_flags Hugh Dickins
2009-09-25 8:30 ` Nigel Cunningham
2009-09-25 11:36 ` Hugh Dickins
2009-09-25 11:47 ` Nigel Cunningham
2009-09-30 12:02 ` Pavel Machek
2009-09-30 13:08 ` swsusp on nommu, was 'Re: No more bits in vm_area_struct's vm_flags.' Johannes Weiner
2009-09-30 16:06 ` Mike Frysinger
2009-09-24 1:05 ` No more bits in vm_area_struct's vm_flags KAMEZAWA Hiroyuki
2009-09-25 8:34 ` Nigel Cunningham
2009-09-25 8:40 ` KAMEZAWA Hiroyuki
2009-09-25 8:48 ` Nigel Cunningham
2009-09-25 21:09 ` Joerg Roedel
2009-09-28 2:45 ` Nigel Cunningham
2009-09-28 3:04 ` KAMEZAWA Hiroyuki
2009-09-28 3:36 ` Wu Fengguang
2009-09-28 3:57 ` KAMEZAWA Hiroyuki
2009-09-28 4:37 ` Nigel Cunningham
2009-09-28 4:51 ` Wu Fengguang
2009-09-28 4:53 ` KAMEZAWA Hiroyuki
2009-09-28 5:22 ` Nigel Cunningham [this message]
2009-09-28 5:32 ` KAMEZAWA Hiroyuki
2009-09-28 21:21 ` Hugh Dickins
2009-09-28 21:33 ` Nigel Cunningham
2009-09-28 15:38 ` Hugh Dickins
2009-09-28 16:14 ` KAMEZAWA Hiroyuki
2009-09-28 21:00 ` Hugh Dickins
2009-09-28 21:22 ` Nigel Cunningham
2009-09-29 1:57 ` KAMEZAWA Hiroyuki
2009-09-29 14:22 ` Christoph Lameter
2009-10-01 10:54 ` Hugh Dickins
2009-10-01 13:47 ` Christoph Lameter
2009-10-01 11:38 ` Hugh Dickins
2009-10-02 0:42 ` KAMEZAWA Hiroyuki
2009-10-02 1:37 ` KAMEZAWA Hiroyuki
2009-10-02 2:39 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC04800.70708@crca.org.au \
--to=ncunningham@crca.org.au \
--cc=fengguang.wu@intel.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).