From: Rik van Riel <riel@redhat.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Larry Woodman <lwoodman@redhat.com>
Subject: Re: [PATCH 5/7] Don't deactivate the page if trylock_page() is failed.
Date: Sun, 06 Dec 2009 15:34:28 -0500 [thread overview]
Message-ID: <4B1C1554.5060007@redhat.com> (raw)
In-Reply-To: <20091204174347.58A0.A69D9226@jp.fujitsu.com>
On 12/04/2009 03:44 AM, KOSAKI Motohiro wrote:
> From 7635eaa033cfcce7f351b5023952f23f0daffefe Mon Sep 17 00:00:00 2001
> From: KOSAKI Motohiro<kosaki.motohiro@jp.fujitsu.com>
> Date: Fri, 4 Dec 2009 12:03:07 +0900
> Subject: [PATCH 5/7] Don't deactivate the page if trylock_page() is failed.
>
> Currently, wipe_page_reference() increment refctx->referenced variable
> if trylock_page() is failed. but it is meaningless at all.
> shrink_active_list() deactivate the page although the page was
> referenced. The page shouldn't be deactivated with young bit. it
> break reclaim basic theory and decrease reclaim throughput.
>
> This patch introduce new SWAP_AGAIN return value to
> wipe_page_reference().
>
> Signed-off-by: KOSAKI Motohiro<kosaki.motohiro@jp.fujitsu.com>
Reviewed-by: Rik van Riel <riel@redhat.com>
--
All rights reversed.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-12-06 20:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-04 8:40 [RFC][PATCH 0/7] some page_referenced() improvement KOSAKI Motohiro
2009-12-04 8:41 ` [PATCH 1/7] Replace page_mapping_inuse() with page_mapped() KOSAKI Motohiro
2009-12-07 11:27 ` Johannes Weiner
2009-12-04 8:42 ` [PATCH 2/7] Introduce __page_check_address KOSAKI Motohiro
2009-12-06 14:55 ` Rik van Riel
2009-12-04 8:42 ` [PATCH 3/7] VM_LOCKED check don't need pte lock KOSAKI Motohiro
2009-12-06 19:41 ` Rik van Riel
2009-12-04 8:43 ` [PATCH 4/7] Replace page_referenced() with wipe_page_reference() KOSAKI Motohiro
2009-12-06 20:31 ` Rik van Riel
2009-12-04 8:44 ` [PATCH 5/7] Don't deactivate the page if trylock_page() is failed KOSAKI Motohiro
2009-12-06 20:34 ` Rik van Riel [this message]
2009-12-04 8:45 ` [PATCH 6/7] wipe_page_reference return SWAP_AGAIN if VM pressulre is low and lock contention is detected KOSAKI Motohiro
2009-12-06 21:01 ` Rik van Riel
2009-12-04 8:46 ` [PATCH 7/7] Try to mark PG_mlocked if wipe_page_reference find VM_LOCKED vma KOSAKI Motohiro
2009-12-06 21:03 ` Rik van Riel
2009-12-07 9:25 ` [RFC][PATCH 0/7] some page_referenced() improvement KOSAKI Motohiro
2009-12-07 11:36 ` [early RFC][PATCH 8/7] vmscan: Don't deactivate many touched page KOSAKI Motohiro
2009-12-07 18:10 ` Rik van Riel
2009-12-08 6:27 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B1C1554.5060007@redhat.com \
--to=riel@redhat.com \
--cc=aarcange@redhat.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lwoodman@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).