From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with SMTP id 90A966B0047 for ; Wed, 6 Jan 2010 02:25:26 -0500 (EST) Message-ID: <4B443AE3.2080800@linux.intel.com> Date: Wed, 06 Jan 2010 15:25:23 +0800 From: Haicheng Li MIME-Version: 1.0 Subject: [PATCH v3] slab: initialize unused alien cache entry as NULL at alloc_alien_cache(). Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Christoph Lameter , linux-mm@kvack.org Cc: Matt Mackall , Pekka Enberg , Andi Kleen , Eric Dumazet , linux-kernel@vger.kernel.org List-ID: Comparing with existing code, it's a simpler way to use kzalloc_node() to ensure that each unused alien cache entry is NULL. CC: Pekka Enberg CC: Eric Dumazet Acked-by: Andi Kleen Acked-by: Christoph Lameter Reviewed-by: Matt Mackall Signed-off-by: Haicheng Li --- mm/slab.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/mm/slab.c b/mm/slab.c index 7dfa481..5d1a782 100644 --- a/mm/slab.c +++ b/mm/slab.c @@ -971,13 +971,11 @@ static struct array_cache **alloc_alien_cache(int node, int limit, gfp_t gfp) if (limit > 1) limit = 12; - ac_ptr = kmalloc_node(memsize, gfp, node); + ac_ptr = kzalloc_node(memsize, gfp, node); if (ac_ptr) { for_each_node(i) { - if (i == node || !node_online(i)) { - ac_ptr[i] = NULL; + if (i == node || !node_online(i)) continue; - } ac_ptr[i] = alloc_arraycache(node, limit, 0xbaadf00d, gfp); if (!ac_ptr[i]) { for (i--; i >= 0; i--) -- 1.5.3.8 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org