From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Haicheng Li <haicheng.li@linux.intel.com>
Cc: Christoph Lameter <cl@linux-foundation.org>,
linux-mm@kvack.org, Matt Mackall <mpm@selenic.com>,
Andi Kleen <andi@firstfloor.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] slab: initialize unused alien cache entry as NULL at alloc_alien_cache().
Date: Wed, 06 Jan 2010 10:42:28 +0200 [thread overview]
Message-ID: <4B444CF4.50606@cs.helsinki.fi> (raw)
In-Reply-To: <4B444C39.3020901@linux.intel.com>
Hi,
Haicheng Li wrote:
> Pekka Enberg wrote:
> > I can find a trace of Andi acking the previous version of this patch
> > but I don't see an ACK from Christoph nor a revieved-by from Matt. Was
> > I not CC'd on those emails or what's going on here?
> >
>
> Christoph said he will ack this patch if remove the change of
> MAX_NUMNODES (see below),
> so I add him directly as Acked-by in this revised patch. And also, I got
> review
> comments from Matt for v1 and changed the patch accordingly.
>
> Is it a violation of the rule? if so, I'm sorry, actually not quite
> clear with the rule.
See Section 14 of Documentation/SubmittingPatches. You should never add
tags unless they came from the said person. The ACKs from Andi is fine,
the one from Christoph is borderline but OK and the one from Matt is
_not_ OK.
I can fix those up but I'll wait from an explicit ACK from Christoph first.
Pekka
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-01-06 8:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-06 7:25 [PATCH v3] slab: initialize unused alien cache entry as NULL at alloc_alien_cache() Haicheng Li
2010-01-06 8:20 ` Pekka Enberg
2010-01-06 8:39 ` Haicheng Li
2010-01-06 8:42 ` Pekka Enberg [this message]
2010-01-06 8:46 ` Haicheng Li
2010-01-07 17:57 ` Christoph Lameter
2010-01-07 12:11 ` Pekka Enberg
2010-01-07 18:10 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B444CF4.50606@cs.helsinki.fi \
--to=penberg@cs.helsinki.fi \
--cc=andi@firstfloor.org \
--cc=cl@linux-foundation.org \
--cc=eric.dumazet@gmail.com \
--cc=haicheng.li@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).