From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with SMTP id 357056B007B for ; Wed, 6 Jan 2010 03:46:36 -0500 (EST) Message-ID: <4B444DE8.1040609@linux.intel.com> Date: Wed, 06 Jan 2010 16:46:32 +0800 From: Haicheng Li MIME-Version: 1.0 Subject: Re: [PATCH v3] slab: initialize unused alien cache entry as NULL at alloc_alien_cache(). References: <4B443AE3.2080800@linux.intel.com> <84144f021001060020v57535d5bwc65b482eca669bc5@mail.gmail.com> <4B444C39.3020901@linux.intel.com> <4B444CF4.50606@cs.helsinki.fi> In-Reply-To: <4B444CF4.50606@cs.helsinki.fi> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Pekka Enberg Cc: Christoph Lameter , linux-mm@kvack.org, Matt Mackall , Andi Kleen , Eric Dumazet , linux-kernel@vger.kernel.org List-ID: understood. thanks! Pekka Enberg wrote: > Hi, > > Haicheng Li wrote: >> Pekka Enberg wrote: >> > I can find a trace of Andi acking the previous version of this patch >> > but I don't see an ACK from Christoph nor a revieved-by from Matt. Was >> > I not CC'd on those emails or what's going on here? >> > >> >> Christoph said he will ack this patch if remove the change of >> MAX_NUMNODES (see below), >> so I add him directly as Acked-by in this revised patch. And also, I >> got review >> comments from Matt for v1 and changed the patch accordingly. >> >> Is it a violation of the rule? if so, I'm sorry, actually not quite >> clear with the rule. > > See Section 14 of Documentation/SubmittingPatches. You should never add > tags unless they came from the said person. The ACKs from Andi is fine, > the one from Christoph is borderline but OK and the one from Matt is > _not_ OK. > > I can fix those up but I'll wait from an explicit ACK from Christoph first. > > Pekka -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org