From: Rik van Riel <riel@redhat.com>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH 2/3][v2] vmstat: add anon_scan_ratio field to zoneinfo
Date: Sun, 17 Jan 2010 21:16:06 -0500 [thread overview]
Message-ID: <4B53C466.4010103@redhat.com> (raw)
In-Reply-To: <28c262361001171810w544614b7rdd3df0f984692f35@mail.gmail.com>
On 01/17/2010 09:10 PM, Minchan Kim wrote:
> Absoultely right. I missed that. Thanks.
> get_scan_ratio used lru_lock to get reclaim_stat->recent_xxxx.
> But, it doesn't used lru_lock to get ap/fp.
>
> Is it intentional? I think you or Rik know it. :)
> I think if we want to get exact value, we have to use lru_lock until
> getting ap/fp.
> If it isn't, we don't need lru_lock when we get the reclaim_stat->recent_xxxx.
>
> What do you think about it?
This is definately not intentional.
Getting race conditions in this code could throw off the
statistics by a factor 2. I do not know how serious that
would be for the VM or whether (and how quickly) it would
self correct.
--
All rights reversed.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-01-18 2:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-13 8:19 [PATCH 1/3] vmscan: get_scan_ratio cleanup KOSAKI Motohiro
2010-01-13 8:21 ` [PATCH 2/3][v2] vmstat: add anon_scan_ratio field to zoneinfo KOSAKI Motohiro
2010-01-13 10:31 ` Minchan Kim
2010-01-13 23:50 ` KOSAKI Motohiro
2010-01-14 5:12 ` Minchan Kim
2010-01-14 5:18 ` KOSAKI Motohiro
2010-01-15 17:23 ` Minchan Kim
2010-01-18 1:04 ` KOSAKI Motohiro
2010-01-18 1:47 ` Minchan Kim
2010-01-18 1:54 ` KOSAKI Motohiro
2010-01-18 2:10 ` Minchan Kim
2010-01-18 2:14 ` KOSAKI Motohiro
2010-01-18 2:16 ` Rik van Riel [this message]
2010-01-18 2:24 ` KOSAKI Motohiro
2010-01-18 2:25 ` Minchan Kim
2010-01-13 8:22 ` [PATCH 3/3] [v2] memcg: add anon_scan_ratio to memory.stat file KOSAKI Motohiro
2010-01-13 8:24 ` KAMEZAWA Hiroyuki
2010-01-13 9:08 ` Balbir Singh
2010-01-13 9:54 ` [PATCH 1/3] vmscan: get_scan_ratio cleanup Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B53C466.4010103@redhat.com \
--to=riel@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).