From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"nishimura@mxp.nes.nec.co.jp" <nishimura@mxp.nes.nec.co.jp>,
kirill@shutemov.name
Subject: Re: [PATCH mmotm] memcg use generic percpu allocator instead of private one
Date: Wed, 20 Jan 2010 18:16:43 +0530 [thread overview]
Message-ID: <4B56FB33.2090408@linux.vnet.ibm.com> (raw)
In-Reply-To: <20100120184707.ed99b540.kamezawa.hiroyu@jp.fujitsu.com>
On Wednesday 20 January 2010 03:17 PM, KAMEZAWA Hiroyuki wrote:
> On Wed, 20 Jan 2010 15:07:52 +0530
> Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
>
>> On Wednesday 20 January 2010 12:48 PM, KAMEZAWA Hiroyuki wrote:
>>> This patch is onto mmotm Jan/15.
>>> =
>>> From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
>>>
>>> When per-cpu counter for memcg was implemneted, dynamic percpu allocator
>>> was not very good. But now, we have good one and useful macros.
>>> This patch replaces memcg's private percpu counter implementation with
>>> generic dynamic percpu allocator and macros.
>>>
>>> The benefits are
>>> - We can remove private implementation.
>>> - The counters will be NUMA-aware. (Current one is not...)
>>> - This patch reduces sizeof(struct mem_cgroup). Then,
>>> struct mem_cgroup may be fit in page size on small config.
>>>
>>> By this, size of text is reduced.
>>> [Before]
>>> [kamezawa@bluextal mmotm-2.6.33-Jan15]$ size mm/memcontrol.o
>>> text data bss dec hex filename
>>> 24373 2528 4132 31033 7939 mm/memcontrol.o
>>> [After]
>>> [kamezawa@bluextal mmotm-2.6.33-Jan15]$ size mm/memcontrol.o
>>> text data bss dec hex filename
>>> 23913 2528 4132 30573 776d mm/memcontrol.o
>>>
>>> This includes no functional changes.
>>>
>>> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
>>
>>
>> Before review, could you please post parallel pagefault data on a large
>> system, since root now uses these per cpu counters and its overhead is
>> now dependent on these counters. Also the data read from root cgroup is
>> also dependent on these, could you make sure that is not broken.
>>
> No number difference before/after patch on my SMP quick test.
> But I don't have NUMA. Could you test on NUMA ?
>
> I'll measure again tomorrow if I have machine time.
I'll do the same as well if possible.
Balbir
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-01-20 12:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-20 7:18 [PATCH mmotm] memcg use generic percpu allocator instead of private one KAMEZAWA Hiroyuki
2010-01-20 9:37 ` Balbir Singh
2010-01-20 9:47 ` KAMEZAWA Hiroyuki
2010-01-20 12:46 ` Balbir Singh [this message]
2010-01-21 2:07 ` KAMEZAWA Hiroyuki
2010-01-21 15:30 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B56FB33.2090408@linux.vnet.ibm.com \
--to=balbir@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nishimura@mxp.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).