From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with SMTP id 793FD6B00AA for ; Tue, 26 Jan 2010 12:22:49 -0500 (EST) Message-ID: <4B5F2467.6030701@redhat.com> Date: Tue, 26 Jan 2010 12:20:39 -0500 From: Rik van Riel MIME-Version: 1.0 Subject: Re: [PATCH 15 of 31] special pmd_trans_* functions References: <98da7b804fb624c399a3.1264513930@v2.random> In-Reply-To: <98da7b804fb624c399a3.1264513930@v2.random> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Andrea Arcangeli Cc: linux-mm@kvack.org, Marcelo Tosatti , Adam Litke , Avi Kivity , Izik Eidus , Hugh Dickins , Nick Piggin , Mel Gorman , Andi Kleen , Dave Hansen , Benjamin Herrenschmidt , Ingo Molnar , Mike Travis , KAMEZAWA Hiroyuki , Christoph Lameter , Chris Wright , Andrew Morton , bpicco@redhat.com, Christoph Hellwig , KOSAKI Motohiro List-ID: On 01/26/2010 08:52 AM, Andrea Arcangeli wrote: > From: Andrea Arcangeli > > These returns 0 at compile time when the config option is disabled, to allow > gcc to eliminate the transparent hugepage function calls at compile time > without additional #ifdefs (only the export of those functions have to be > visible to gcc but they won't be required at link time and huge_memory.o can be > not built at all). > > Signed-off-by: Andrea Arcangeli Acked-by: Rik van Riel Took me a few minutes to figure out why reusing that bit in the page table entry is safe. IMHO that could use a more verbose changelog message. -- All rights reversed. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org