From: Huang Shijie <shijie8@gmail.com>
To: Hugh Dickins <hugh.dickins@tiscali.co.uk>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org
Subject: Re: [PATCH] swapfile : fix the wrong return value
Date: Thu, 04 Mar 2010 15:48:30 +0800 [thread overview]
Message-ID: <4B8F65CE.5090501@gmail.com> (raw)
In-Reply-To: <alpine.LSU.2.00.1003040706400.3894@sister.anvils>
> Yes. Well, we are debating the likelihoods of corruption in different memory
> areas here. I answer "Yes" because the swap entry involved in try_to_unmap_one()
> comes from page->private when PageSwapCache is set (and the page is locked):
> it requires either an mm bug, or corruption of struct page, for that swap entry
> to be invalid for duplication. Memory corruption of entries in a user page
> table seems to have been a more common case, whether because of single-bit memory
> errors, or use-after-free bugs: that's the case which copy_one_pte() might meet.
>
:), ok, thanks a lot for your kind explanations.
>
>
>> For the sake of the stability of the system, I perfer to export all the error
>> value, and check it carefully.
>>
> But we were happy with void swap_duplicate() for many years.
> If I wanted to make a further change, it would rather be to remove those
> error returns from __swap_duplicate() which are not actually made use of.
>
> Hugh
>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-03-04 7:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-02 3:38 [PATCH] swapfile : fix the wrong return value Huang Shijie
2010-03-04 0:37 ` Hugh Dickins
2010-03-04 7:00 ` Huang Shijie
2010-03-04 7:28 ` Hugh Dickins
2010-03-04 7:48 ` Huang Shijie [this message]
2010-03-04 7:14 ` [PATCH] swapfile : export more return values for swap_duplicate() Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B8F65CE.5090501@gmail.com \
--to=shijie8@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hugh.dickins@tiscali.co.uk \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).