From: Avi Kivity <avi@redhat.com>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: Huang Shijie <shijie8@gmail.com>,
akpm@linux-foundation.org, hugh.dickins@tiscali.co.uk,
linux-mm@kvack.org, Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [PATCH] kvm : remove redundant initialization of page->private
Date: Thu, 11 Mar 2010 09:42:26 +0200 [thread overview]
Message-ID: <4B989EE2.30803@redhat.com> (raw)
In-Reply-To: <1268231482.1254.28.camel@barrios-desktop>
On 03/10/2010 04:31 PM, Minchan Kim wrote:
>
> The prep_new_page() in page allocator calls set_page_private(page, 0).
> So we don't need to reinitialize private of page.
>
>
Applied, thanks. Please copy the kvm mailing list in the future on kvm
patches.
> diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
> index 741373e..9851d0e 100644
> --- a/arch/x86/kvm/mmu.c
> +++ b/arch/x86/kvm/mmu.c
> @@ -326,7 +326,6 @@ static int mmu_topup_memory_cache_page(struct kvm_mmu_memory_cache *cache,
> page = alloc_page(GFP_KERNEL);
> if (!page)
> return -ENOMEM;
> - set_page_private(page, 0);
> cache->objects[cache->nobjs++] = page_address(page);
> }
> return 0;
>
Jan, this is kvm-kmod unfriendly. kvm_alloc_page()?
--
error compiling committee.c: too many arguments to function
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-03-11 7:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-08 9:33 [PATCH] shmem : remove redundant code Huang Shijie
2010-03-08 16:04 ` Minchan Kim
2010-03-09 2:02 ` Huang Shijie
2010-03-08 16:20 ` [PATCH] kvm : remove redundant initialization of page->private Minchan Kim
2010-03-10 10:19 ` Avi Kivity
2010-03-10 14:31 ` Minchan Kim
2010-03-11 7:42 ` Avi Kivity [this message]
2010-03-11 8:51 ` Jan Kiszka
2010-03-11 8:55 ` Avi Kivity
2010-03-11 18:43 ` Hugh Dickins
2010-03-09 21:25 ` [PATCH] shmem : remove redundant code Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B989EE2.30803@redhat.com \
--to=avi@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hugh.dickins@tiscali.co.uk \
--cc=jan.kiszka@siemens.com \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=shijie8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).