From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail202.messagelabs.com (mail202.messagelabs.com [216.82.254.227]) by kanga.kvack.org (Postfix) with SMTP id 8FC696B01E3 for ; Mon, 12 Apr 2010 13:07:05 -0400 (EDT) Received: from chimera.site ([71.245.98.113]) by xenotime.net for ; Mon, 12 Apr 2010 10:07:00 -0700 Message-ID: <4BC35333.5030704@xenotime.net> Date: Mon, 12 Apr 2010 10:06:59 -0700 From: Randy Dunlap MIME-Version: 1.0 Subject: Re: hugepages will matter more in the future References: <20100410194751.GA23751@elte.hu> <4BC0DE84.3090305@redhat.com> <4BC0E2C4.8090101@redhat.com> <4BC0E556.30304@redhat.com> <4BC19663.8080001@redhat.com> <4BC19916.20100@redhat.com> <20100411110015.GA10149@elte.hu> <4BC1B034.4050302@redhat.com> <20100411115229.GB10952@elte.hu> <4BC1EE13.7080702@redhat.com> <4BC34837.7020108@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Linus Torvalds Cc: Rik van Riel , Avi Kivity , Ingo Molnar , Jason Garrett-Glaser , Mike Galbraith , Andrea Arcangeli , Pekka Enberg , Andrew Morton , linux-mm@kvack.org, Marcelo Tosatti , Adam Litke , Izik Eidus , Hugh Dickins , Nick Piggin , Mel Gorman , Dave Hansen , Benjamin Herrenschmidt , Mike Travis , KAMEZAWA Hiroyuki , Christoph Lameter , Chris Wright , bpicco@redhat.com, KOSAKI Motohiro , Balbir Singh , Arnd Bergmann , "Michael S. Tsirkin" , Peter Zijlstra , Johannes Weiner , Daisuke Nishimura , Arjan van de Ven List-ID: On 04/12/10 09:56, Linus Torvalds wrote: > > > On Mon, 12 Apr 2010, Linus Torvalds wrote: >> >> So as I already commented to Andrew, the code has no comments about the >> "big picture", and the largest comment I found was about a totally >> _trivial_ issue about replacing the hugepage by first clearing the entry, >> then flushing the tlb, and then filling it. > > Btw, this is the same complaint I had about the anon_vma code. There was > no overview comments, and some of my fixes to that came directly from > writing a big-picture "what should happen" flow chart, and either noticing > that the code didn't do what it should have done, or that even the big > picture was not clear. > > And yes, I do realize that historically we (I) haven't been good at those > things. It's just that the VM has gotten _so_ complicated that we damn > well need them, at least when we add new features that the rest of the VM > team doesn't know by rote. and we can't expect Mel (or anyone) to write MM/VM books continuously, which is what it would take since it's always changing, so useful comments are the way to go. -- ~Randy -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org