From: Pekka Enberg <penberg@cs.helsinki.fi>
To: TAO HU <tghk48@motorola.com>, Nick Piggin <npiggin@suse.de>
Cc: linux-kernel@vger.kernel.org, cl@linux-foundation.org,
mpm@selenic.com, linux-mm@kvack.org, dwmw2@infradead.org,
TAO HU <taohu@motorola.com>,
ShiYong LI <shi-yong.li@motorola.com>,
david.rientjes@google.com
Subject: Re: [PATCH - V2] Fix missing of last user while dumping slab corruption log
Date: Tue, 13 Apr 2010 12:32:44 +0300 [thread overview]
Message-ID: <4BC43A3C.7010603@cs.helsinki.fi> (raw)
In-Reply-To: <h2v5f4a33681004130005xc06eadf7jc94e9257c6af4350@mail.gmail.com>
TAO HU kirjoitti:
> Actually we greped "kmem_cache_create" in whole kernel souce tree
> (2.6.29 and 2.6.32).
>
> Either "align" equal to "0" or flag SLAB_HWCACHE_ALIGN is used when
> calling kmem_cache_create().
I don't think that's correct. The "task_xstate" has alignof(struct
task_xstate) and there seems to be so GCC attributes that force
non-default alignment on the struct.
> Seems all of arch's cache-line-size is multiple of 64-bit/8-byte
> (sizeof(long long)) except arch-microblaze (4-byte).
> The smallest (except arch-microblaze) cache-line-size is 2^4= 16-byte
> as I can see.
> So even considering possible sizeof(long long) == 128-bit/16-byte, it
> is still safe to apply Shiyong's original version.
>
> Anyway, Shiyong's new patch check the weired situation that "align >
> sizeof(long long) && align is NOT multiple of sizeof (long long)"
> Let us know whether the new version address your concerns.
Yeah, sorry for dragging this issue on. I've been looking at the patch
but haven't been able to convince myself that it's correct. Nick, David,
Christoph, Matt, could you also please take a look at this?
Pekka
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-04-13 9:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-12 5:50 [PATCH - V2] Fix missing of last user while dumping slab corruption log ShiYong LI
2010-04-13 7:05 ` TAO HU
2010-04-13 9:32 ` Pekka Enberg [this message]
2010-04-14 17:56 ` Pekka Enberg
2010-04-15 3:04 ` TAO HU
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BC43A3C.7010603@cs.helsinki.fi \
--to=penberg@cs.helsinki.fi \
--cc=cl@linux-foundation.org \
--cc=david.rientjes@google.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=npiggin@suse.de \
--cc=shi-yong.li@motorola.com \
--cc=taohu@motorola.com \
--cc=tghk48@motorola.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).