From: Tejun Heo <tj@kernel.org>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: Christoph Lameter <cl@linux-foundation.org>,
Mel Gorman <mel@csn.ul.ie>,
Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Bob Liu <lliubbo@gmail.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages
Date: Mon, 19 Apr 2010 06:22:20 +0900 [thread overview]
Message-ID: <4BCB780C.1030001@kernel.org> (raw)
In-Reply-To: <1271606079.2100.159.camel@barrios-desktop>
On 04/19/2010 12:54 AM, Minchan Kim wrote:
>> alloc_pages is the same as alloc_pages_any_node so why have it?
>
> I don't want to force using '_node' postfix on UMA users.
> Maybe they don't care getting page from any node and event don't need to
> know about _NODE_.
Yeah, then, remove alloc_pages_any_node(). I can't really see the
point of any_/exact_node. alloc_pages() and alloc_pages_node() are
fine and in line with other functions. Why change it?
>> Why remove it? If you want to get rid of -1 handling then check all the
>
> alloc_pages_node have multiple meaning as you said. So some of users
> misuses that API. I want to clear intention of user.
The name is fine. Just clean up the users and make the intended usage
clear in documentation and implementation (ie. trigger a big fat
warning) and make all the callers use named constants instead of -1
for special meanings.
Thanks.
--
tejun
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-04-18 21:19 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-13 15:24 [PATCH 1/6] Remove node's validity check in alloc_pages Minchan Kim
2010-04-13 15:24 ` [PATCH 2/6] change alloc function in pcpu_alloc_pages Minchan Kim
2010-04-13 15:48 ` Mel Gorman
2010-04-14 23:39 ` Tejun Heo
2010-04-15 1:31 ` Minchan Kim
2010-04-15 7:21 ` Tejun Heo
2010-04-15 8:00 ` Minchan Kim
2010-04-15 8:15 ` Tejun Heo
2010-04-15 9:40 ` Minchan Kim
2010-04-15 10:08 ` Tejun Heo
2010-04-15 10:21 ` Minchan Kim
2010-04-15 10:33 ` Minchan Kim
2010-04-15 11:43 ` Tejun Heo
2010-04-15 11:49 ` Minchan Kim
2010-04-16 16:07 ` Christoph Lameter
2010-04-16 19:13 ` Lee Schermerhorn
2010-04-18 15:55 ` Minchan Kim
2010-04-18 15:54 ` Minchan Kim
2010-04-18 21:22 ` Tejun Heo [this message]
2010-04-19 0:03 ` Minchan Kim
2010-04-19 17:45 ` Christoph Lameter
2010-04-20 0:20 ` Minchan Kim
2010-04-19 17:38 ` Christoph Lameter
2010-04-19 22:27 ` Tejun Heo
2010-04-20 15:05 ` Mel Gorman
2010-04-21 10:48 ` Tejun Heo
2010-04-22 10:15 ` Minchan Kim
2010-04-21 14:15 ` Christoph Lameter
2010-04-21 17:06 ` Minchan Kim
2010-04-13 15:25 ` [PATCH 3/6] change alloc function in alloc_slab_page Minchan Kim
2010-04-13 15:52 ` Mel Gorman
2010-04-13 16:01 ` Minchan Kim
2010-04-13 16:14 ` Mel Gorman
2010-04-13 21:37 ` David Rientjes
2010-04-13 23:40 ` Minchan Kim
2010-04-13 23:55 ` David Rientjes
2010-04-14 0:02 ` Minchan Kim
2010-04-14 0:18 ` KAMEZAWA Hiroyuki
2010-04-14 12:23 ` Pekka Enberg
2010-04-16 16:10 ` Christoph Lameter
2010-04-18 18:49 ` Pekka Enberg
2010-04-19 9:05 ` Mel Gorman
2010-04-13 15:25 ` [PATCH 4/6] change alloc function in vmemmap_alloc_block Minchan Kim
2010-04-13 15:59 ` Mel Gorman
2010-04-14 0:19 ` KAMEZAWA Hiroyuki
2010-04-13 15:25 ` [PATCH 5/6] change alloc function in __vmalloc_area_node Minchan Kim
2010-04-13 16:02 ` Mel Gorman
2010-04-14 0:22 ` KAMEZAWA Hiroyuki
2010-04-14 0:33 ` Minchan Kim
2010-04-13 15:25 ` [PATCH 6/6] Add comment in alloc_pages_exact_node Minchan Kim
2010-04-13 16:13 ` Mel Gorman
2010-04-13 16:20 ` Minchan Kim
2010-04-13 15:32 ` [PATCH 1/6] Remove node's validity check in alloc_pages Mel Gorman
2010-04-14 0:04 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BCB780C.1030001@kernel.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lliubbo@gmail.com \
--cc=mel@csn.ul.ie \
--cc=minchan.kim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).