From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail202.messagelabs.com (mail202.messagelabs.com [216.82.254.227]) by kanga.kvack.org (Postfix) with SMTP id 001EB6B0227 for ; Tue, 11 May 2010 08:11:07 -0400 (EDT) Message-ID: <4BE94935.9090200@redhat.com> Date: Tue, 11 May 2010 08:10:29 -0400 From: Rik van Riel MIME-Version: 1.0 Subject: Re: [PATCH] mm,migration: Avoid race between shift_arg_pages() and rmap_walk() during migration by not migrating temporary stacks References: <20100511085752.GM26611@csn.ul.ie> In-Reply-To: <20100511085752.GM26611@csn.ul.ie> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Mel Gorman Cc: Andrew Morton , Linus Torvalds , KAMEZAWA Hiroyuki , Linux-MM , LKML , Minchan Kim , Christoph Lameter , Andrea Arcangeli , Peter Zijlstra List-ID: On 05/11/2010 04:57 AM, Mel Gorman wrote: > Hi Andrew, > > This patch closes the most important race in relation to exec and > migration. With it applied, the swapops bug is no longer triggering for > known problem workloads. If you pick it up, it should go with the other > mmmigration-* fixes in mm. > This patch causes pages within the temporary stack during exec to be skipped > by migration. It does this by marking the VMA covering the temporary stack > with an otherwise impossible combination of VMA flags. These flags are > cleared when the temporary stack is moved to its final location. > > [kamezawa.hiroyu@jp.fujitsu.com: Idea for having migration skip temporary stacks] > Signed-off-by: Mel Gorman > Reviewed-by: KAMEZAWA Hiroyuki Reviewed-by: Rik van Riel -- All rights reversed -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org