From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with SMTP id 699496B01EE for ; Thu, 13 May 2010 22:01:31 -0400 (EDT) Message-ID: <4BECAEF6.2090009@linux.intel.com> Date: Fri, 14 May 2010 10:01:26 +0800 From: Haicheng Li MIME-Version: 1.0 Subject: Re: [RFC, 3/7] NUMA hotplug emulator References: <20100513114835.GD2169@shaohui> <20100513165511.GB25212@suse.de> In-Reply-To: <20100513165511.GB25212@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Greg KH Cc: akpm@linux-foundation.org, linux-mm@kvack.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Hidetoshi Seto , David Rientjes , Alex Chiang , linux-kernel@vger.kernel.org, ak@linux.intel.com, fengguang.wu@intel.com, shaohui.zheng@linux.intel.com List-ID: Greg KH wrote: >> Add a sysfs entry "probe" under /sys/devices/system/node/: >> >> - to show all fake offlined nodes: >> $ cat /sys/devices/system/node/probe >> >> - to hotadd a fake offlined node, e.g. nodeid is N: >> $ echo N > /sys/devices/system/node/probe > > As you are trying to add a new sysfs file, please create the matching > Documentation/ABI/ file as well. Yes, we missed it. thank you. > Also note that sysfs files are "one value per file", which I don't think > this file follows, right? Sorry, we didn't make the descriptions clear enough. It should follow "one value per file". It intends to show acceptable parameters. For example, if we have 4 fake offlined nodes, like node 2-5, then: $ cat /sys/devices/system/node/probe 2-5 Then user hotadds node3 to system: $ echo 3 > /sys/devices/system/node/probe $ cat /sys/devices/system/node/probe 2,4-5 -haicheng -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org