From: Doug Doan <dougd@cray.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, andi@firstfloor.org,
lee.schermerhorn@hp.com, rientjes@google.com, mel@csn.ul.ie,
akpm@linux-foundation.org
Subject: [PATCH] hugetlb: call mmu notifiers on hugepage cow
Date: Thu, 27 May 2010 13:43:00 -0700 [thread overview]
Message-ID: <4BFED954.8060807@cray.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 440 bytes --]
From: Doug Doan <dougd@cray.com>
When a copy-on-write occurs, we take one of two paths in handle_mm_fault:
through handle_pte_fault for normal pages, or through hugetlb_fault for huge pages.
In the normal page case, we eventually get to do_wp_page and call mmu notifiers
via ptep_clear_flush_notify. There is no callout to the mmmu notifiers in the
huge page case. This patch fixes that.
Signed-off-by: Doug Doan <dougd@cray.com>
---
[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 801 bytes --]
--- mm/hugetlb.c.orig 2010-05-27 13:07:58.569546314 -0700
+++ mm/hugetlb.c 2010-05-26 14:41:06.449296524 -0700
@@ -2345,11 +2345,17 @@ retry_avoidcopy:
ptep = huge_pte_offset(mm, address & huge_page_mask(h));
if (likely(pte_same(huge_ptep_get(ptep), pte))) {
/* Break COW */
+ mmu_notifier_invalidate_range_start(mm,
+ address & huge_page_mask(h),
+ (address & huge_page_mask(h)) + huge_page_size(h));
huge_ptep_clear_flush(vma, address, ptep);
set_huge_pte_at(mm, address, ptep,
make_huge_pte(vma, new_page, 1));
/* Make the old page be freed below */
new_page = old_page;
+ mmu_notifier_invalidate_range_end(mm,
+ address & huge_page_mask(h),
+ (address & huge_page_mask(h)) + huge_page_size(h));
}
page_cache_release(new_page);
page_cache_release(old_page);
next reply other threads:[~2010-05-27 20:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-27 20:43 Doug Doan [this message]
2010-05-28 9:59 ` [PATCH] hugetlb: call mmu notifiers on hugepage cow Mel Gorman
2010-05-28 16:39 ` Doug Doan
2010-05-28 17:34 ` Mel Gorman
2010-06-02 6:16 ` Andrew Morton
2010-06-02 23:13 ` Doug Doan
2010-06-02 23:33 ` Andrew Morton
2010-06-03 17:36 ` Doug Doan
2010-06-03 18:11 ` Andrew Morton
2010-06-03 18:35 ` Doug Doan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFED954.8060807@cray.com \
--to=dougd@cray.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=lee.schermerhorn@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).