From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail190.messagelabs.com (mail190.messagelabs.com [216.82.249.51]) by kanga.kvack.org (Postfix) with SMTP id CF5E26B01D0 for ; Mon, 14 Jun 2010 15:43:27 -0400 (EDT) Message-ID: <4C168640.6080309@redhat.com> Date: Mon, 14 Jun 2010 15:42:56 -0400 From: Rik van Riel MIME-Version: 1.0 Subject: Re: [PATCH 10/12] vmscan: Update isolated page counters outside of main path in shrink_inactive_list() References: <1276514273-27693-1-git-send-email-mel@csn.ul.ie> <1276514273-27693-11-git-send-email-mel@csn.ul.ie> In-Reply-To: <1276514273-27693-11-git-send-email-mel@csn.ul.ie> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Mel Gorman Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Dave Chinner , Chris Mason , Nick Piggin , Johannes Weiner , Christoph Hellwig , KAMEZAWA Hiroyuki , Andrew Morton List-ID: On 06/14/2010 07:17 AM, Mel Gorman wrote: > When shrink_inactive_list() isolates pages, it updates a number of > counters using temporary variables to gather them. These consume stack > and it's in the main path that calls ->writepage(). This patch moves the > accounting updates outside of the main path to reduce stack usage. > > Signed-off-by: Mel Gorman > Reviewed-by: Johannes Weiner Acked-by: Rik van Riel -- All rights reversed -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org