From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with SMTP id 59EC06B022D for ; Tue, 15 Jun 2010 09:34:52 -0400 (EDT) Message-ID: <4C17815A.8080402@redhat.com> Date: Tue, 15 Jun 2010 09:34:18 -0400 From: Rik van Riel MIME-Version: 1.0 Subject: Re: [PATCH 12/12] vmscan: Do not writeback pages in direct reclaim References: <1276514273-27693-1-git-send-email-mel@csn.ul.ie> <1276514273-27693-13-git-send-email-mel@csn.ul.ie> <4C16A567.4080000@redhat.com> <20100615114510.GE26788@csn.ul.ie> In-Reply-To: <20100615114510.GE26788@csn.ul.ie> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Mel Gorman Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Dave Chinner , Chris Mason , Nick Piggin , Johannes Weiner , Christoph Hellwig , KAMEZAWA Hiroyuki , Andrew Morton List-ID: On 06/15/2010 07:45 AM, Mel Gorman wrote: > On Mon, Jun 14, 2010 at 05:55:51PM -0400, Rik van Riel wrote: >> On 06/14/2010 07:17 AM, Mel Gorman wrote: >> >>> diff --git a/mm/vmscan.c b/mm/vmscan.c >>> index 4856a2a..574e816 100644 >>> --- a/mm/vmscan.c >>> +++ b/mm/vmscan.c >>> @@ -372,6 +372,12 @@ int write_reclaim_page(struct page *page, struct address_space *mapping, >>> return PAGE_SUCCESS; >>> } >>> >>> +/* kswapd and memcg can writeback as they are unlikely to overflow stack */ >>> +static inline bool reclaim_can_writeback(struct scan_control *sc) >>> +{ >>> + return current_is_kswapd() || sc->mem_cgroup != NULL; >>> +} >>> + >> >> I'm not entirely convinced on this bit, but am willing to >> be convinced by the data. >> > > Which bit? > > You're not convinced that kswapd should be allowed to write back? > You're not convinced that memcg should be allowed to write back? > You're not convinced that direct reclaim writing back pages can overflow > the stack? If direct reclaim can overflow the stack, so can direct memcg reclaim. That means this patch does not solve the stack overflow, while admitting that we do need the ability to get specific pages flushed to disk from the pageout code. -- All rights reversed -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org