From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with ESMTP id 351B05F0040 for ; Thu, 21 Oct 2010 22:52:19 -0400 (EDT) Message-ID: <4CC0FBDC.4010700@zytor.com> Date: Thu, 21 Oct 2010 19:50:04 -0700 From: "H. Peter Anvin" MIME-Version: 1.0 Subject: Re: [GIT PULL] memblock for 2.6.37 References: <201010220050.o9M0ognt032167@hera.kernel.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Linus Torvalds Cc: "H. Peter Anvin" , Benjamin Herrenschmidt , CAI Qian , "David S. Miller" , Felipe Balbi , Ingo Molnar , Jan Beulich , Jeremy Fitzhardinge , Jeremy Fitzhardinge , Kevin Hilman , Linux Kernel Mailing List , Michael Ellerman , Michal Simek , Paul Mundt , Peter Zijlstra , Russell King , Russell King , Stephen Rothwell , Thomas Gleixner , Tomi Valkeinen , Vivek Goyal , Yinghai Lu , ext Grazvydas Ignotas , linux-mm@kvack.org List-ID: On 10/21/2010 06:59 PM, Linus Torvalds wrote: > On Thu, Oct 21, 2010 at 5:50 PM, H. Peter Anvin wrote: >> >> The unmerged branch is at: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git core-memblock-for-linus >> >> The premerged branch is at: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git core-memblock-for-linus-merged > > I always tend to take the unmerged version, because I want to see what > the conflicts are (it gives me some view of what clashes), but when > people do pre-merges I then try to compare my merge against theirs. > Sounds like a very good idea. I'll take it as a request to continue to do both if there are anything but trivial conflicts. > However, in this case, your pre-merged version differs. But I think > it's your merge that was incorrect. You left this line: > > obj-$(CONFIG_HAVE_EARLY_RES) += early_res.o > > in kernel/Makefile, even though kernel/early_res.c is gone. > > I'll push out my merge, but please do verify that it all looks ok. > > Linus > You're right, my mistake. Thanks for checking and fixing it up. I will pull your tree later and test if and add the fixes for the other trees. -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org