From: Tejun Heo <tj@kernel.org>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@linux.com>,
linux-mm@kvack.org
Subject: Re: [patch 2/3] mm: remove gfp mask from pcpu_get_vm_areas
Date: Thu, 18 Nov 2010 07:29:56 +0100 [thread overview]
Message-ID: <4CE4C7E4.50402@kernel.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1011171229040.30790@chino.kir.corp.google.com>
Hello,
On 11/17/2010 09:32 PM, David Rientjes wrote:
> A recent thread[*] shows a problem whereas gfp masks may be passed into
> the vmalloc interface that restrict reclaim behavior, yet the underlying
> pte allocator unconditionally uses GFP_KERNEL. This is a first-pass at an
> effort to remove all gfp_t formals from the vmalloc interface (and can be
> completed once gfs2, ntfs, and ceph have converted) and require them to
> use GFP_KERNEL.
I see.
> Luckily for the per-cpu allocator, this was trivial since that happens to
> be the only use case already.
per-cpu allocator intentionally only allowed GFP_KERNEL till now.
There were some requests about allowing GFP_ATOMIC allocations and
that's the reason why the @gfp is there for the vm function. Anyways,
this looks like the nail in that coffin.
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-11-18 6:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 3:41 [patch 1/3] mm: remove unused get_vm_area_node David Rientjes
2010-11-17 3:41 ` [patch 2/3] mm: remove gfp mask from pcpu_get_vm_areas David Rientjes
2010-11-17 9:08 ` Tejun Heo
2010-11-17 20:32 ` David Rientjes
2010-11-18 6:29 ` Tejun Heo [this message]
2010-11-17 3:41 ` [patch 3/3] mm: unify module_alloc code for vmalloc David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE4C7E4.50402@kernel.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).