From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Matt Mackall <mpm@selenic.com>
Cc: b32542@freescale.com, linux-mm@kvack.org,
cl@linux-foundation.org, tytso@mit.edu,
linux-kernel@vger.kernel.org,
Zeng Zhaoming <zengzm.kernel@gmail.com>
Subject: Re: [PATCH] slub: operate cache name memory same to slab and slob
Date: Thu, 18 Nov 2010 23:41:24 +0200 [thread overview]
Message-ID: <4CE59D84.4050501@cs.helsinki.fi> (raw)
In-Reply-To: <1290114908.26343.721.camel@calx>
On 18.11.2010 23.15, Matt Mackall wrote:
> On Thu, 2010-11-18 at 11:00 +0800, b32542@freescale.com wrote:
>> From: Zeng Zhaoming<zengzm.kernel@gmail.com>
>>
>> Get a memory leak complaint about ext4:
>> comm "mount", pid 1159, jiffies 4294904647 (age 6077.804s)
>> hex dump (first 32 bytes):
>> 65 78 74 34 5f 67 72 6f 75 70 69 6e 66 6f 5f 31 ext4_groupinfo_1
>> 30 00 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b a5 0.kkkkkkkkkkkkk.
>> backtrace:
>> [<c068ade3>] kmemleak_alloc+0x93/0xd0
>> [<c024e54c>] __kmalloc_track_caller+0x30c/0x380
>> [<c02269d3>] kstrdup+0x33/0x60
>> [<c0318a70>] ext4_mb_init+0x4e0/0x550
>> [<c0304e0e>] ext4_fill_super+0x1e6e/0x2f60
>> [<c0261140>] mount_bdev+0x1c0/0x1f0
>> [<c02fc00f>] ext4_mount+0x1f/0x30
>> [<c02603d8>] vfs_kern_mount+0x78/0x250
>> [<c026060e>] do_kern_mount+0x3e/0x100
>> [<c027b4c2>] do_mount+0x2e2/0x780
>> [<c027ba04>] sys_mount+0xa4/0xd0
>> [<c010429f>] sysenter_do_call+0x12/0x38
>> [<ffffffff>] 0xffffffff
>>
>> It is cause by slub manage the cache name different from slab and slob.
>> In slab and slob, only reference to name, alloc and reclaim the memory
>> is the duty of the code that invoked kmem_cache_create().
>>
>> In slub, cache name duplicated when create. This ambiguity will cause
>> some memory leaks and double free if kmem_cache_create() pass a
>> dynamic malloc cache name.
>
> I don't get it.
>
> Caller allocates X, passes X to slub, slub duplicates X as X', and
> properly frees X', then caller frees X. Yes, that's silly, but where's
> the leak?
>
> But slub and slab should obviously both manage names in the same way,
> namely the historical "caller allocates" way. So:
>
> Acked-by: Matt Mackall<mpm@selenic.com>
The kstrdup() is there because of SLUB cache merging. See commit
84c1cf62465e2fb0a692620dcfeb52323ab03d48 ("SLUB: Fix merged slab cache
names") for details.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2010-11-18 21:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 3:00 [PATCH] slub: operate cache name memory same to slab and slob b32542
2010-11-18 21:15 ` Matt Mackall
2010-11-18 21:36 ` David Rientjes
2010-11-18 22:27 ` Matt Mackall
2010-11-19 14:38 ` Zeng Zhaoming
2010-11-21 0:55 ` David Rientjes
2010-11-18 21:41 ` Pekka Enberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE59D84.4050501@cs.helsinki.fi \
--to=penberg@cs.helsinki.fi \
--cc=b32542@freescale.com \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=tytso@mit.edu \
--cc=zengzm.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).