From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail202.messagelabs.com (mail202.messagelabs.com [216.82.254.227]) by kanga.kvack.org (Postfix) with SMTP id 16AA76B0071 for ; Sun, 21 Nov 2010 13:07:32 -0500 (EST) Message-ID: <4CE95FD7.1060805@redhat.com> Date: Sun, 21 Nov 2010 13:07:19 -0500 From: Rik van Riel MIME-Version: 1.0 Subject: Re: [PATCH] vmscan: Make move_active_pages_to_lru more generic References: <1290349496-13297-1-git-send-email-minchan.kim@gmail.com> In-Reply-To: <1290349496-13297-1-git-send-email-minchan.kim@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Minchan Kim Cc: Andrew Morton , linux-mm , LKML , Wu Fengguang , KOSAKI Motohiro , Johannes Weiner List-ID: On 11/21/2010 09:24 AM, Minchan Kim wrote: > Now move_active_pages_to_lru can move pages into active or inactive. > if it moves the pages into inactive, it itself can clear PG_acive. > It makes the function more generic. > diff --git a/mm/vmscan.c b/mm/vmscan.c > index aa4f1cb..bd408b3 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1457,6 +1457,10 @@ static void move_active_pages_to_lru(struct zone *zone, > VM_BUG_ON(PageLRU(page)); > SetPageLRU(page); > > + /* we are de-activating */ > + if (!is_active_lru(lru)) > + ClearPageActive(page); > + Does that mean we also want code to ensure that pages have the PG_active bit set when we add them to an active list? -- All rights reversed -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org