From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail190.messagelabs.com (mail190.messagelabs.com [216.82.249.51]) by kanga.kvack.org (Postfix) with SMTP id BCB546B004A for ; Sun, 28 Nov 2010 23:28:19 -0500 (EST) Message-ID: <4CF32BD5.8050006@redhat.com> Date: Sun, 28 Nov 2010 23:28:05 -0500 From: Rik van Riel MIME-Version: 1.0 Subject: Re: [PATCH v2 3/3] Prevent promotion of page in madvise_dontneed References: <7b50614882592047dfd96f6ca2bb2d0baa8f5367.1290956059.git.minchan.kim@gmail.com> <48315b5fe54efa08982aa7df77e8abe793889e3a.1290956059.git.minchan.kim@gmail.com> In-Reply-To: <48315b5fe54efa08982aa7df77e8abe793889e3a.1290956059.git.minchan.kim@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Minchan Kim Cc: Andrew Morton , linux-mm , LKML , Ben Gamari , KOSAKI Motohiro , Johannes Weiner , Nick Piggin , Mel Gorman , Wu Fengguang List-ID: On 11/28/2010 10:02 AM, Minchan Kim wrote: > Now zap_pte_range alwayas promotes pages which are pte_young&& > !VM_SequentialReadHint(vma). But in case of calling MADV_DONTNEED, > it's unnecessary since the page wouldn't use any more. > > If the page is sharred by other processes and it's real working set This line seems to be superfluous, I don't see any special treatment for this case in the code. > Signed-off-by: Minchan Kim > Cc: Rik van Riel > Cc: KOSAKI Motohiro > Cc: Johannes Weiner > Cc: Nick Piggin > Cc: Mel Gorman > Cc: Wu Fengguang The patch itself looks good to me. Acked-by: Rik van Riel -- All rights reversed -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org