From: Ingo Korb <ingo@akana.de>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org, mel@csn.ul.ie,
cl@linux-foundation.org, yinghai@kernel.org,
andi.kleen@intel.com, linux-kernel@vger.kernel.org
Subject: Re: PROBLEM: __offline_isolated_pages may offline too many pages
Date: Wed, 15 Dec 2010 10:25:51 +0100 [thread overview]
Message-ID: <4D08899F.4050502@akana.de> (raw)
In-Reply-To: <20101215092134.e2c8849f.kamezawa.hiroyu@jp.fujitsu.com>
On 15.12.2010 01:21, KAMEZAWA Hiroyuki wrote:
> It's designed for offline memory section> MAX_ORDER. pageblock_nr_pages
> is tend to be smaller than that.
>
> Do you see the problem with _exsisting_ user interface of memory hotplug ?
> I think we have no control other than memory section.
The existing, exported interface (remove_memory() - the check itself is
in offline_pages()) only checks if both start and end of the
to-be-removed block are aligned to pageblock_nr_pages. As you noted the
actual size and alignment requirements in __offline_isolated_pages can
be larger that that, so I think the checks in offline_pages() should be
changed (if 1<<MAX_ORDER is always >= pageblock_nr_pages) or extended
(if there can be any relation between the two).
-ik
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-12-15 9:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-14 15:01 PROBLEM: __offline_isolated_pages may offline too many pages Ingo Korb
2010-12-15 0:21 ` KAMEZAWA Hiroyuki
2010-12-15 9:25 ` Ingo Korb [this message]
2010-12-16 0:06 ` KAMEZAWA Hiroyuki
2010-12-16 10:26 ` Mel Gorman
2010-12-16 23:57 ` [PATCH] memory hotplug: fix alignment check (Was " KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D08899F.4050502@akana.de \
--to=ingo@akana.de \
--cc=akpm@linux-foundation.org \
--cc=andi.kleen@intel.com \
--cc=cl@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).